2303 modal path navigation #2505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdoberschuetz
requested review from
alexandra-simeonova,
hardl,
JohannesDoberer,
ndricimrr,
rafalgamon,
stanleychh and
UlianaMunich
as code owners
|
@wdoberschuetz please ask @JohannesDoberer or @hardl about this warning in Match Found |
Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
alexandra-simeonova
approved these changes
Feb 14, 2022
JohannesDoberer
requested changes
Feb 14, 2022
There was a problem hiding this comment.
Before we merge this PR we need to revert all changes in core/example/luigi-example-angular. This project is only an example how angular and luigi works together. I would say we keep it until it is approved because we can test the client-support-angular lib in this project.
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.4.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](unshiftio/url-parse@1.4.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…rschuetz/luigi into 2303-modal-path-navigation
JohannesDoberer
approved these changes
Mar 10, 2022
…rschuetz/luigi into 2303-modal-path-navigation
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
modalPathParamnow available incore,clientandclient-frameworks-support/client-support-angular/projects/client-support-angularRelated issue(s)
Resolves #2303
How to test
core,clientandclient-frameworks-support/client-support-angular/projects/client-support-angularcore/examples/luigi-example-angular/node_modules/@luigi-projectand paste for each of the folders what you've builtclient-frameworks-supportgo toclient-frameworks-support\client-support-angular\dist\client-support-angularand copy the folders and files to thecore\examples\luigi-example-angular\node_modules\@luigi-project\client-support-angularcorego tocore/publicand copy theluigi.jsandluigi.svelte.map.jstonode_modules/@luigi-project/coreclientgo toclient/publicand copy the whole folder tonode_modules/@luigi-project/client