[FIX] Bundler: Ensure reproducibility for bundles with multiple parts #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sort modules in preload sections alphabetically. This caused different bundle contents based on the order of modules that the resolver provides, which is not deterministic. Remove terser from size estimation as modules are now already optimized if the 'optimize' bundle option is enabled. This caused incorrect estimations about the bundle size which resulted into size differences of the individual parts.
|
Tests need to be updated / enhanced |
matz3
force-pushed
the
next-fix-AutoSplitter-reproducibility
branch
from
a3a9244
to
10e6ce6
Compare
RandomByte
approved these changes
Jan 25, 2022
This was referenced Mar 30, 2022
Closed
This was referenced May 4, 2022
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort modules in preload sections alphabetically.
This caused different bundle contents based on the order of modules that
the resolver provides, which is not deterministic.
Remove terser from size estimation as modules are now already optimized
if the 'optimize' bundle option is enabled.
This caused incorrect estimations about the bundle size which resulted
into size differences of the individual parts.