feat: fallback to latest supported patch version #687
Merged
+1,270
−553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 825e962 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
vadson71
force-pushed
the
feat/27819/fallbackToLatestPatch
branch
from
93823ce to
d615382
Compare
voicis
reviewed
Jan 5, 2024
voicis
approved these changes
Jan 5, 2024
…into feat/27819/fallbackToLatestPatch # Conflicts: # packages/context/src/types.ts # packages/context/src/ui5-model.ts # packages/context/test/unit/ui5-model.test.ts # packages/language-server/test/unit/completion-items-classes.test.ts # packages/language-server/test/unit/completion-items-literals.test.ts # packages/language-server/test/unit/completion-items.test.ts # packages/language-server/test/unit/documentation.test.ts # packages/language-server/test/unit/hover.test.ts # packages/language-server/test/unit/quick-fix.test.ts # packages/language-server/test/unit/snapshots/xml-view-diagnostics/snapshots-utils.ts # packages/logic-utils/test/unit/find-classes-matching.test.ts # packages/logic-utils/test/unit/get-super-class.test.ts # packages/logic-utils/test/unit/xml-node-to-ui5-node.test.ts # packages/semantic-model/test/unit/api.test.ts # packages/semantic-model/test/unit/unit.test.ts # packages/semantic-model/test/unit/utils.test.ts # packages/xml-views-completion/test/unit/api.test.ts # packages/xml-views-completion/test/unit/providers/attributeName/namespace.test.ts # packages/xml-views-completion/test/unit/providers/attributeName/prop-event-assoc.test.ts # packages/xml-views-completion/test/unit/providers/attributeValue/boolean-literal.test.ts # packages/xml-views-completion/test/unit/providers/attributeValue/enum.test.ts # packages/xml-views-completion/test/unit/providers/attributeValue/namespace.test.ts # packages/xml-views-completion/test/unit/providers/elementName/aggregation.test.ts # packages/xml-views-completion/test/unit/providers/elementName/classes.test.ts # packages/xml-views-tooltip/test/unit/tooltip.test.ts # packages/xml-views-validation/test/unit/api.test.ts # packages/xml-views-validation/test/unit/validators/attributes/invalid-boolean-value.test.ts # packages/xml-views-validation/test/unit/validators/attributes/unknown-attribute-key.test.ts # packages/xml-views-validation/test/unit/validators/attributes/unknown-enum-value.test.ts # packages/xml-views-validation/test/unit/validators/attributes/unknown-xmlns-namespace.test.ts # packages/xml-views-validation/test/unit/validators/attributes/use-of-depracated-attribute.test.ts # packages/xml-views-validation/test/unit/validators/document/non-unique-id.test.ts # packages/xml-views-validation/test/unit/validators/element/cardinality-of-aggregation.test.ts # packages/xml-views-validation/test/unit/validators/element/non-stable-id.test.ts # packages/xml-views-validation/test/unit/validators/element/type-of-aggregation.test.ts # packages/xml-views-validation/test/unit/validators/element/use-of-deprecated-aggregation.test.ts # packages/xml-views-validation/test/unit/validators/element/use-of-deprecated-class.test.ts # test-packages/test-utils/api.d.ts # test-packages/test-utils/src/utils/semantic-model-provider.ts
marufrasully
reviewed
Jan 9, 2024
| import semverMinSatisfying from "semver/ranges/min-satisfying"; | ||
| import { Response } from "node-fetch"; | ||
|
|
||
| const GET_MODEL_TIMEOUT = 30000; |
There was a problem hiding this comment.
any specific reason to have this timeout? By default it pick this https://github.com/SAP/ui5-language-assistant/blob/master/jest.setup.js#L1
There was a problem hiding this comment.
It is used it tests where semantic model is downloaded from internet resources. In rare cases requests to server may take long while (due to some network issues for instance). In that case the shorter timeout will help to push forward the pending test execution
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.