Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fallback to latest supported patch version #687

Merged
merged 9 commits into from
Jan 10, 2024
Merged

feat: fallback to latest supported patch version #687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d615382
fix: fallback to latest supported patch version
vadson71 Jan 5, 2024
4dadf27
fix: function docs and pr comments
vadson71 Jan 5, 2024
1306762
Merge branch 'master' of https://github.com/SAP/ui5-language-assistan…
vadson71 Jan 8, 2024
5f3ec49
fix: readme file correction
vadson71 Jan 8, 2024
6ad6ef9
Merge branch 'master' into feat/27819/fallbackToLatestPatch
vadson71 Jan 10, 2024
116563e
Merge branch 'master' into feat/27819/fallbackToLatestPatch
vadson71 Jan 10, 2024
8cd8aa8
Merge branch 'master' into feat/27819/fallbackToLatestPatch
vadson71 Jan 10, 2024
d532404
fix: work on pr comments
vadson71 Jan 10, 2024
825e962
fix: linter
vadson71 Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .changeset/cool-days-itch.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
---
"@ui5-language-assistant/xml-views-completion": patch
"@ui5-language-assistant/xml-views-validation": patch
"@ui5-language-assistant/xml-views-tooltip": patch
"@ui5-language-assistant/language-server": patch
"@ui5-language-assistant/test-utils": patch
"@ui5-language-assistant/semantic-model": patch
"@ui5-language-assistant/logic-utils": patch
"@ui5-language-assistant/context": patch
"vscode-ui5-language-assistant": patch
"@ui5-language-assistant/vscode-ui5-language-assistant-bas-ext": patch
---

Fallback to the latest supported patch version
27 changes: 27 additions & 0 deletions .vscode/launch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
"args": [
"${fileBasenameNoExtension}",
"--coverage=false",
"--maxWorkers=1",
"--config",
"jest.config.js"
],
Expand All @@ -68,6 +69,7 @@
"args": [
"${fileBasenameNoExtension}",
"--coverage=false",
"--maxWorkers=1",
"--config",
"jest.config.js"
],
Expand All @@ -87,6 +89,7 @@
"args": [
"${fileBasenameNoExtension}",
"--coverage=false",
"--maxWorkers=1",
"--config",
"jest.config.js"
],
Expand All @@ -106,6 +109,7 @@
"args": [
"${fileBasenameNoExtension}",
"--coverage=false",
"--maxWorkers=1",
"--config",
"jest.config.js"
],
Expand All @@ -117,6 +121,26 @@
},
"cwd": "${workspaceFolder}/packages/xml-views-validation"
},
{
"type": "node",
"request": "launch",
"name": "XML completion: Run Current Jest File",
"program": "${workspaceFolder}/node_modules/.bin/jest",
"args": [
"${fileBasenameNoExtension}",
"--coverage=false",
"--maxWorkers=1",
"--config",
vadson71 marked this conversation as resolved.
Show resolved Hide resolved
"jest.config.js"
],
"console": "integratedTerminal",
"internalConsoleOptions": "neverOpen",
"disableOptimisticBPs": true,
"windows": {
"program": "${workspaceFolder}/node_modules/jest/bin/jest"
},
"cwd": "${workspaceFolder}/packages/xml-views-completion"
},
{
"type": "node",
"request": "launch",
Expand All @@ -125,6 +149,7 @@
"args": [
"${fileBasenameNoExtension}",
"--coverage=false",
"--maxWorkers=1",
"--config",
"jest.config.js"
],
Expand All @@ -144,6 +169,7 @@
"args": [
"${fileBasenameNoExtension}",
"--coverage=false",
"--maxWorkers=1",
"--config",
"jest.config.js"
],
Expand All @@ -163,6 +189,7 @@
"args": [
"${fileBasenameNoExtension}",
"--coverage=false",
"--maxWorkers=1",
"--config",
"jest.config.js"
],
Expand Down
3 changes: 2 additions & 1 deletion packages/context/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { FetchResponse } from "@ui5-language-assistant/logic-utils";

export const DEFAULT_UI5_FRAMEWORK = "SAPUI5";
export const DEFAULT_UI5_VERSION = "1.71.61";
export const DEFAULT_UI5_VERSION_BASE = "1.71";
export const UI5_VERSION_S4_PLACEHOLDER = "${sap.ui5.dist.version}";
export const UI5_FRAMEWORK_CDN_BASE_URL = {
OpenUI5: "https://sdk.openui5.org/",
Expand Down Expand Up @@ -113,4 +114,4 @@ export type CAPProjectKind = "Java" | "NodeJS";
export type ProjectKind = CAPProjectKind | "UI5";
export type Project = UI5Project | CAPProject;
export type ProjectType = typeof UI5_PROJECT_TYPE | typeof CAP_PROJECT_TYPE;
export type Fetcher = (url: string) => Promise<FetchResponse>;
export type Fetcher<T = unknown> = (url: string) => Promise<FetchResponse<T>>;
Loading