[BREAKING] Implement Project Graph, build execution #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 13, 2022
RandomByte
force-pushed
the
ui5-project-3.0
branch
2 times, most recently
from
265e4b6
to
a28e27d
Compare
* Replace the JSON-object based dependency tree handling with a graph
representation
* Projects are now represented by classes with documented APIs
* Projects can be accessed by extensions defining specVersion >=2.7
* Speed up resolution of package.json dependencies
* Make "ui5.dependencies" package.json configuration obsolete
* Move build execution from ui5-builder to ui5-project
* ui5-builder scope reduced top provides task implementations only
* Build: Determine automatically whether a project-build requires
dependencies to be built and build them
* Build: Add new option 'createBuildManifest'. This will create a
manifest file in the target directory that allows reuse of the
build result of library and theme-library projects in other project
builds (RFC0011)
This PR will need additional follow-up to add more test cases,
cleanup JSDoc and possibly add more features described in the RFCs.
This is a nicer version of
#394
Implements RFC0009: SAP/ui5-tooling#501
Implements RFC0011: SAP/ui5-tooling#612
BREAKING CHANGE:
* normalizer and projectTree APIs have been removed. Use
generateProjectGraph instead
* Going forward only specification versions 2.0 and higher are supported
* In case a legacy specification version is detected, an automatic,
transparent migration is attempted.
* Build:
* The "dev" build mode has been removed
* The task "generateVersionInfo" is no longer executed for
application projects by default. You may enable it again using the
includedTasks parameter
Access to middlewareRepository is no longer necessary
Will create additional tests in follow-up PRs
Resolves depcheck issue for missing dependency to @ui5/project
RandomByte
force-pushed
the
ui5-project-3.0
branch
from
1826513
to
f4dd597
Compare
matz3
approved these changes
Jun 13, 2022
RandomByte
added a commit
to SAP/ui5-builder
that referenced
this pull request
Jun 13, 2022
Build execution is moved to ui5-project (see SAP/ui5-project#457). Going forward, ui5-builder shall only provide task implementations and selected helper modules like TaskUtil. TaskUtil will provide a new `getProject()` function to custom tasks defining specVersion 2.7 and above. BREAKING CHANGE: * builder.js has been removed. Use ui5-project builder instead * Tasks now rely on Project instances being available on Resources (see SAP/ui5-fs#381) * TaskRepository#addTask has been removed. Custom tasks need to be added to the project graph instead * TaskUtil#get/set/clearTag now requires a Project instance to be provided. Path strings are no longer sufficient and will cause an exception to be thrown Co-authored-by: Matthias Osswald <mat.osswald@sap.com>
RandomByte
added a commit
to SAP/ui5-server
that referenced
this pull request
Jun 13, 2022
Adapt to new Project Graph API (see SAP/ui5-project#457) BREAKING CHANGE: * Server now requires a Project Graph instance instead. * Standard middleware now rely on Project instances being available on Resources (see SAP/ui5-fs#381) * MiddlewareRepository#addMiddleware has been removed. Custom middleware need to be added to the project graph instead
RandomByte
added a commit
to SAP/ui5-cli
that referenced
this pull request
Jun 13, 2022
Adapt to new ui5-project Project Graph and builder APIs: SAP/ui5-project#457 BREAKING CHANGES: * Removed CLI option `--translator`. Use new option `--dependency-definition` to provide a file with static dependency information * Removed `ui5 build dev` command * Refactored `ui5 tree`: Removed `--full`, `--json` and `--dedupe` options Co-authored-by: Matthias Osswald <mat.osswald@sap.com>
flovogt
pushed a commit
to SAP/ui5-builder
that referenced
this pull request
Jun 14, 2022
Build execution is moved to ui5-project (see SAP/ui5-project#457). Going forward, ui5-builder shall only provide task implementations and selected helper modules like TaskUtil. TaskUtil will provide a new `getProject()` function to custom tasks defining specVersion 2.7 and above. BREAKING CHANGE: * builder.js has been removed. Use ui5-project builder instead * Tasks now rely on Project instances being available on Resources (see SAP/ui5-fs#381) * TaskRepository#addTask has been removed. Custom tasks need to be added to the project graph instead * TaskUtil#get/set/clearTag now requires a Project instance to be provided. Path strings are no longer sufficient and will cause an exception to be thrown Co-authored-by: Matthias Osswald <mat.osswald@sap.com>
This was referenced Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
representation
dependencies to be built and build them
manifest file in the target directory that allows reuse of the
build result of library and theme-library projects in other project
builds (RFC0011)
This PR will need additional follow-up to add more test cases,
cleanup JSDoc and possibly add more features described in the RFCs.
This is a nicer version of
#394
Implements RFC0009: SAP/ui5-tooling#501
Implements RFC0011: SAP/ui5-tooling#612
BREAKING CHANGE:
generateProjectGraph instead
transparent migration is attempted.
application projects by default. You may enable it again using the
includedTasks parameter