-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] 0009 UI5 Project Refactoring #501
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
RandomByte
added a commit
to SAP/ui5-project
that referenced
this pull request
Jun 13, 2022
* Replace the JSON-object based dependency tree handling with a graph representation * Projects are now represented by classes with documented APIs * Projects can be accessed by extensions defining specVersion >=2.7 * Speed up resolution of package.json dependencies * Make "ui5.dependencies" package.json configuration obsolete * Move build execution from ui5-builder to ui5-project * ui5-builder scope reduced top provides task implementations only * Build: Determine automatically whether a project-build requires dependencies to be built and build them * Build: Add new option 'createBuildManifest'. This will create a manifest file in the target directory that allows reuse of the build result of library and theme-library projects in other project builds (RFC0011) This PR will need additional follow-up to add more test cases, cleanup JSDoc and possibly add more features described in the RFCs. This is a nicer version of #394 Implements RFC0009: SAP/ui5-tooling#501 Implements RFC0011: SAP/ui5-tooling#612 BREAKING CHANGE: * normalizer and projectTree APIs have been removed. Use generateProjectGraph instead * Going forward only specification versions 2.0 and higher are supported * In case a legacy specification version is detected, an automatic, transparent migration is attempted. * Build: * The "dev" build mode has been removed * The task "generateVersionInfo" is no longer executed for application projects by default. You may enable it again using the includedTasks parameter
RandomByte
added a commit
to SAP/ui5-project
that referenced
this pull request
Jun 13, 2022
* Replace the JSON-object based dependency tree handling with a graph representation * Projects are now represented by classes with documented APIs * Projects can be accessed by extensions defining specVersion >=2.7 * Speed up resolution of package.json dependencies * Make "ui5.dependencies" package.json configuration obsolete * Move build execution from ui5-builder to ui5-project * ui5-builder scope reduced top provides task implementations only * Build: Determine automatically whether a project-build requires dependencies to be built and build them * Build: Add new option 'createBuildManifest'. This will create a manifest file in the target directory that allows reuse of the build result of library and theme-library projects in other project builds (RFC0011) This PR will need additional follow-up to add more test cases, cleanup JSDoc and possibly add more features described in the RFCs. This is a nicer version of #394 Implements RFC0009: SAP/ui5-tooling#501 Implements RFC0011: SAP/ui5-tooling#612 BREAKING CHANGE: * normalizer and projectTree APIs have been removed. Use generateProjectGraph instead * Going forward only specification versions 2.0 and higher are supported * In case a legacy specification version is detected, an automatic, transparent migration is attempted. * Build: * The "dev" build mode has been removed * The task "generateVersionInfo" is no longer executed for application projects by default. You may enable it again using the includedTasks parameter
RandomByte
added a commit
to SAP/ui5-project
that referenced
this pull request
Jun 13, 2022
* Replace the JSON-object based dependency tree handling with a graph representation * Projects are now represented by classes with documented APIs * Projects can be accessed by extensions defining specVersion >=2.7 * Speed up resolution of package.json dependencies * Make "ui5.dependencies" package.json configuration obsolete * Move build execution from ui5-builder to ui5-project * ui5-builder scope reduced top provides task implementations only * Build: Determine automatically whether a project-build requires dependencies to be built and build them * Build: Add new option 'createBuildManifest'. This will create a manifest file in the target directory that allows reuse of the build result of library and theme-library projects in other project builds (RFC0011) This PR will need additional follow-up to add more test cases, cleanup JSDoc and possibly add more features described in the RFCs. This is a nicer version of #394 Implements RFC0009: SAP/ui5-tooling#501 Implements RFC0011: SAP/ui5-tooling#612 BREAKING CHANGE: * normalizer and projectTree APIs have been removed. Use generateProjectGraph instead * Going forward only specification versions 2.0 and higher are supported * In case a legacy specification version is detected, an automatic, transparent migration is attempted. * Build: * The "dev" build mode has been removed * The task "generateVersionInfo" is no longer executed for application projects by default. You may enable it again using the includedTasks parameter
Most of this got implemented on the v3 branch with SAP/ui5-project#457 |
RandomByte
force-pushed
the
rfc-project-refactoring
branch
from
November 2, 2022 14:02
13872f6
to
61fe5a4
Compare
This RFC got implemented in the UI5 Tooling v3 development branch. See also: https://sap.github.io/ui5-tooling/updates/migrate-v3/ |
Initial draft
RandomByte
force-pushed
the
rfc-project-refactoring
branch
from
November 3, 2022 14:02
61fe5a4
to
b088374
Compare
matz3
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of this has been implemented in UI5 Tooling v3 alpha
Feedback always welcome!
Read it here: [RFC] 0009 UI5 Project Refactoring