[FIX] Resolve properly absolute path for ui5HomeDir #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matz3
requested changes
Mar 7, 2023
matz3
approved these changes
Mar 7, 2023
d3xter666
added a commit
that referenced
this pull request
Mar 30, 2023
d3xter666
added a commit
that referenced
this pull request
Apr 3, 2023
d3xter666
added a commit
that referenced
this pull request
Apr 12, 2023
d3xter666
added a commit
that referenced
this pull request
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix resolves SAP/ui5-tooling#796
The core issue is that in particular CI environments
os.homedir()might be enforced to return a relative path.We rely only on absolute paths in the tooling, so we'd need to ensure this.