[FIX] Makes CSP middleware work in an environment without express server #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With change 4f05967, the CSP middleware made use of 'express' APIs on the request object. When used in an environment without 'express' (e.g. the OpenUI5 legacy grunt tooling), the CSP middleware failed for all requests. It now uses the native NodeJS APIs again. Fixes https://github.com/SAP/ui5-server/issues/183 .
1 similar comment
svbender
approved these changes
May 13, 2019
matz3
added a commit
that referenced
this pull request
May 24, 2019
This makes all middlewares independent of the express specific `req.path` property by manually parsing the standard `req.url`. The `parseurl` library is also used within express and makes sure to not parse the same URL of a request object again by using a cache on the request object. Follow up of #184 Fixes: SAP/karma-ui5#64
3 tasks
matz3
added a commit
that referenced
this pull request
May 27, 2019
This makes all middlewares independent of the express specific `req.path` property by manually parsing the standard `req.url`. The `parseurl` library is also used within express and makes sure to not parse the same URL of a request object again by using a cache on the request object. Follow up of #184 Fixes: SAP/karma-ui5#64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With change 4f05967, the CSP middleware
made use of 'express' APIs on the request object. When used in an
environment without 'express' (e.g. the OpenUI5 legacy grunt tooling),
the CSP middleware failed for all requests.
It now uses the native NodeJS APIs again.
Fixes https://github.com/SAP/ui5-server/issues/183 .
Thank you for your contribution! 🙌
To get it merged faster, kindly review the checklist below:
Pull Request Checklist