Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialog overlay hides page content when there is a message-strip #375

Closed
pskelin opened this issue May 9, 2019 · 1 comment · Fixed by #387
Closed

dialog overlay hides page content when there is a message-strip #375

pskelin opened this issue May 9, 2019 · 1 comment · Fixed by #387
Assignees
Labels
approved This issue is approved bug This issue is a bug in the code

Comments

@pskelin
Copy link
Contributor

pskelin commented May 9, 2019

Describe the bug
Opening a dialog causes the whole page content behind the overlay to disappear

To reproduce
Steps to reproduce the behavior:

  1. Go to https://codesandbox.io/s/p9m5w08q80
  2. Click the open button
  3. The open button disappears

Expected behavior
the open button should be visible behind the overlay. If the message strip is removed from the page the button stays as expected, so this behaviour is influenced by the message strip shomehow.

Screenshots
If applicable, add screenshots to help explain your problem.

Context

  • UI5 Web Components version: 0.10.1
  • OS/Platform: MacOS
  • Browser (if relevant): Chrome
  • Other information: {...}

Affected components
ui5-dialog
ui5-messagestrip

@pskelin pskelin added approved This issue is approved bug This issue is a bug in the code labels May 9, 2019
@ilhan007
Copy link
Member

That is because the message strip has height 100%;

the body grows when the dialog is opened, the message strip takes the whole height and the button disappears (although it`s just bellow the message strip), as the message strip takes the full view port).

@ilhan007 ilhan007 self-assigned this May 14, 2019
ilhan007 added a commit that referenced this issue May 14, 2019
Issue, the message strip used to take full parent height, although it might contain only few words.
Solution: remove the height 100% on element tag, as it can be alter any time by the consumers.
FIXES: #375
ilhan007 added a commit that referenced this issue May 14, 2019
Issue, the message strip used to take full parent height, although it might contain only few words.
Solution: remove the height 100% on element tag, as it can be alter any time by the consumers.
FIXES: #375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is approved bug This issue is a bug in the code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants