fix(ui5-messagestrip): remove height 100% on element tag #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ilhan007
commented
May 14, 2019
ilhan007
commented
- Issue: the message strip used to take full parent height, although it might contain only few words.
- Solution: remove the height 100% on element tag, as it can be altered any time by the consumers.
- FIXES: dialog overlay hides page content when there is a message-strip #375
Issue, the message strip used to take full parent height, although it might contain only few words. Solution: remove the height 100% on element tag, as it can be alter any time by the consumers. FIXES: #375
fifoosid
approved these changes
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.