Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Side Navigation: Errors in console for i18n texts #6436

Closed
1 of 4 tasks
georgimkv opened this issue Feb 7, 2023 · 0 comments · Fixed by #6429
Closed
1 of 4 tasks

Side Navigation: Errors in console for i18n texts #6436

georgimkv opened this issue Feb 7, 2023 · 0 comments · Fixed by #6429
Assignees
@georgimkv
Labels
bug This issue is a bug in the code Medium Prio TOPIC RD

Comments

@georgimkv
Copy link
Contributor

Bug Description

Loading the page https://sap.github.io/ui5-webcomponents/main/playground/components/SideNavigation/ shows errors in the console.

Fix the issues to fix the reported errors.

Context

  • UI5 Web Components version: latest
  • Affected component: ui5-side-navigation

Log Output / Stack Trace / Screenshots

image

Priority

  • Low
  • Medium
  • High
  • Very High
@georgimkv georgimkv added Medium Prio TOPIC RD bug This issue is a bug in the code and removed Medium Prio labels Feb 7, 2023
@s-todorova s-todorova self-assigned this Feb 9, 2023
@georgimkv georgimkv mentioned this issue Feb 13, 2023
Merged
@s-todorova s-todorova removed their assignment Feb 13, 2023
@georgimkv georgimkv self-assigned this Feb 13, 2023
georgimkv added a commit that referenced this issue Feb 20, 2023
@kskondov @georgimkv
feat(ui5-side-navigation): migrate to TypeScript (#6429)
d8ab195 
Related to: #4337
Fixes: #6436

Fixed a bug where clicking on the fixedItems on a collapsed SideNavigation would not open the item's popover.

---------

Co-authored-by: Georgi Minkov <georgi.minkov@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@georgimkv georgimkv

Labels
bug This issue is a bug in the code Medium Prio TOPIC RD
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ui5-side-navigation): migrate to TypeScript SAP/ui5-webcomponents
2 participants
@georgimkv @s-todorova