feat(ui5-side-navigation): migrate to TypeScript #6429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed errors
ilhan007
reviewed
Feb 6, 2023
ilhan007
reviewed
Feb 6, 2023
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
georgimkv
reviewed
Feb 6, 2023
Review comments
I was not able to find a quick fix we might need to address this in another issue |
|
Few changes:
|
georgimkv
previously requested changes
Feb 9, 2023
kskondov
force-pushed
the
TSSideNavigation
branch
from
e9af947 to
f59610b
Compare
Change interface name and remove TempTree
ilhan007
reviewed
Feb 16, 2023
| subItems: Array<SideNavigationSubItem>, | ||
| }; | ||
|
|
||
| type TSideNavigationItem = SideNavigationItem | SideNavigationSubItem; |
There was a problem hiding this comment.
I only would prefer to have ISideNavigationItem interface (instead of TSideNavigationItem), that both SideNavigationItem and SideNavigationSubItem implement
There was a problem hiding this comment.
We discussed this comment offline and it won't help much to have an interface in this case.
ilhan007
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #4337
Fixes: #6436
Fixed a bug where clicking on the fixedItems on a collapsed SideNavigation would not open the item's popover.