-
Notifications
You must be signed in to change notification settings - Fork 24
quadtree csv reader #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quadtree csv reader #186
Conversation
Codecov Report
@@ Coverage Diff @@
## master #186 +/- ##
==========================================
- Coverage 55.84% 55.73% -0.11%
==========================================
Files 20 20
Lines 3560 3572 +12
Branches 568 569 +1
==========================================
+ Hits 1988 1991 +3
- Misses 1452 1460 +8
- Partials 120 121 +1
Continue to review full report at Codecov.
|
csep/utils/readers.py
Outdated
return rates, region, mws | ||
|
||
|
||
def load_quadtree_forecast_csv(csv_fname): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we change this name to quadtree_csv_loader
. Reason: this function name implies that it will return a forecast object. Also should change the name of the other function to quadtree_ascii_loader
.
aside from the comment above, this looks good to merge. |
Can you accept the last two enhancements I added? grid bounds for cartesian gird will be useful for writing generic function for forecast aggregation. And the check for zero cell area is also generally useful. Without this check, the function does not return zero. |
looks good to me ! merging. |
pyCSEP Pull Request Checklist
Please check out the contributing guidelines for some tips
on making pull requests to pyCSEP.
Fixes issue #(please fill in or delete if not needed).
Type of change:
Please delete options that are not relevant.
Checklist: