Fix consistency plots #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: added option to plot test distribution's mean. styl: homogenized plot_poisson_consistency_test and plot_consistency_test
|
@pabloitu is this ready to merge? |
|
this is ready |
feat: added option to plot test distribution's mean. styl: homogenized plot_poisson_consistency_test and plot_consistency_test
…consistency_plots
|
rebased onto v0.6.1_release_branch |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v0.6.1-release-branch #206 +/- ##
========================================================
Coverage ? 54.53%
========================================================
Files ? 20
Lines ? 3660
Branches ? 538
========================================================
Hits ? 1996
Misses ? 1549
Partials ? 115 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #203. Replaces the use of the observed statistic to plot confidence intervals by using error plots. Instead, uses the mean of the distribution, whereas the observed statistic if plot separately. Also, provides the option to plot the mean as a black dot. This change fixes the issue, while I expect to refactor the plotting code for version 0.7.0
Type of change:
Please delete options that are not relevant.
Checklist: