Finish CRAN submission

[pbulsink]

I think it's ready for CRAN submission!

Close Issues #37, #38, #39, #59, merge PR #134, #135.

Unless you think #78 or #123 are outstanding?

[SCasanova]

I do think #123 is important but I think I cracked it yesterday (I want your opinion on my solution)

However as it's not a perfect solution I do think it could remain as a part of the "dev" version post-CRAN

[SCasanova]

Other than that I think we're ready to submit

[pbulsink]

I do think #123 is important but I think I cracked it yesterday (I want your opinion on my solution)

However as it's not a perfect solution I do think it could remain as a part of the "dev" version post-CRAN

Gladly! If you put a PR I can likely fetch from that dev branch.

[SCasanova]

Sorry, I've been very busy. Will push later today

[SCasanova]

On second thought, I think it needs more work. We should go ahead without it for now.

[pbulsink]

Feel free to open a PR from a dev branch and we can collaborate on it, and use master for the cran submission while we wait?

…

On Sun, Jul 23, 2023, 20:19 Santiago Casanova ***@***.***> wrote: On second thought, I think it needs more work. We should go ahead without it for now. — Reply to this email directly, view it on GitHub <#136 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJLHRXCSAXT33C4TZZTTN3XRW5QZANCNFSM6AAAAAA2SD4KLI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[SCasanova]

Sounds good. Should I get the submission going then?

[pbulsink]

I'd say go for it! I've never submitted anything to CRAN before, but I think `devtools` or `usethis` has a helper function to prep whatever files are needed and help through the process.

…

On Mon, Jul 24, 2023, 12:17 Santiago Casanova ***@***.***> wrote: Sounds good. Should I get the submission going then? — Reply to this email directly, view it on GitHub <#136 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJLHRTZRGVX3A6UY7OKTGTXR2NYRANCNFSM6AAAAAA2SD4KLI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[SCasanova]

Will submit it then! I opened a checklist based on https://r-pkgs.org/release.html. So therefore I will now close this issue