Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working on PR actions #134

Merged
merged 9 commits into from
Jul 21, 2023
Merged

Working on PR actions #134

merged 9 commits into from
Jul 21, 2023

Conversation

pbulsink
Copy link
Collaborator

Style & Docs should build before PR is merged...

@pbulsink pbulsink marked this pull request as draft July 20, 2023 00:23
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #134 (5fe2d4f) into master (696559a) will increase coverage by 0.33%.
The diff coverage is 100.00%.

❗ Current head 5fe2d4f differs from pull request most recent head c5a266d. Consider uploading reports for the commit c5a266d to get more accurate results

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
+ Coverage   91.87%   92.21%   +0.33%     
==========================================
  Files          18       18              
  Lines         554      578      +24     
==========================================
+ Hits          509      533      +24     
  Misses         45       45              
Impacted Files Coverage Δ
R/load_schedule.R 100.00% <100.00%> (ø)

@pbulsink pbulsink marked this pull request as ready for review July 20, 2023 01:13
@pbulsink pbulsink marked this pull request as draft July 20, 2023 01:13
@pbulsink pbulsink marked this pull request as ready for review July 20, 2023 01:23
@pbulsink
Copy link
Collaborator Author

Hmmm, looks like it needs GH action permissions expansion for scasanova/f1dataR to commit to pbulsink/f1dataR.

@pbulsink pbulsink marked this pull request as draft July 20, 2023 01:53
pbulsink and others added 2 commits July 20, 2023 06:37
I.e. don't do it if just a PR, but only after push to [master, main]
@pbulsink pbulsink marked this pull request as ready for review July 20, 2023 18:15
@pbulsink pbulsink marked this pull request as draft July 20, 2023 18:15
@pbulsink pbulsink marked this pull request as ready for review July 20, 2023 23:30
@pbulsink
Copy link
Collaborator Author

OK I finally have this sorted. Style & Doc runs (but doesn't try to commit) for a PR. If it's a Push (i.e. when a PR is merged) THEN the style & doc runs AND commits (hopefully without triggering a new GH Actions run!)

@pbulsink pbulsink mentioned this pull request Jul 21, 2023
@SCasanova SCasanova merged commit 95a72ce into SCasanova:master Jul 21, 2023
@pbulsink pbulsink deleted the workflow-fixing branch July 25, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants