Support for URL instead of NSURL

[aheze]

New Feature Request Checklist

• I have checked the current documentations or APIs and did not find a solution
• I have searched for a similar issue in the project and found none

Feature Request Description

Currently, you make a NSURL from PHAsset like this:

// Create with `PHAsset`
let asset: PHAsset
let photosURL = NSURL.sd_URL(with: asset)

// Load image (assume using custom manager)
imageView.sd_setImage(with: photosURL, placeholderImage: nil, context: [.customManager: manager])

However, sd_setImage(with: takes a URL, not NSURL.

I would like to be able to get a URL from PHAsset, something like this:

// Create with `PHAsset`
let asset: PHAsset
let photosURL = URL.sd_URL(with: asset) /// URL not NSURL

// Load image (assume using custom manager)
imageView.sd_setImage(with: photosURL, placeholderImage: nil, context: [.customManager: manager])

This would avoid the error, and I think URLs are safer than NSURLs.

[dreampiggy]

This is limit in current Pure Objective-C implementation...

That NSURL category return type can not been autoamtically converted into URL sturct and may loss information.

[dreampiggy]

Can the Fix-it with as URL? solve the issue ?

[aheze]

@dreampiggy yes, as URL? works.

let asset: PHAsset
let photosURL = NSURL.sd_URL(with: asset)
cell.imageView.sd_setImage(with: photosURL as URL?, placeholderImage: nil) /// this works

[dreampiggy]

I'll update readme now.

For better Swift support, let me find some other way, or provide something like SDWebImage/SDWebImage#2980

Provide this repo as an Objective-C/Swift Mixed project.

[dreampiggy]

@aheze Introduce the convenience API for Swift user. See #21

let asset: PHAsset
let url = asset.sd_URLRepresentation