Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the convenience API to get URL representation from PHAsset object #21

Merged
merged 3 commits into from
Jan 21, 2021

Conversation

dreampiggy
Copy link
Collaborator

This PR added one simple API for Swift user. Which just map to the NSURL category.

This close #18

Now you don't need the as URL.

@dreampiggy dreampiggy mentioned this pull request Jan 21, 2021
2 tasks
@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #21 (2f782d4) into master (eaa2393) will increase coverage by 0.10%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage   63.70%   63.80%   +0.10%     
==========================================
  Files           3        4       +1     
  Lines         270      268       -2     
==========================================
- Hits          172      171       -1     
+ Misses         98       97       -1     
Flag Coverage Δ
iOS 63.80% <50.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tosPlugin/Classes/PHAsset+SDWebImagePhotosPlugin.m 0.00% <0.00%> (ø)
...hotosPlugin/Classes/NSURL+SDWebImagePhotosPlugin.m 89.28% <100.00%> (+8.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaa2393...58fdf4c. Read the comment docs.

@dreampiggy dreampiggy merged commit c56d532 into master Jan 21, 2021
@dreampiggy dreampiggy deleted the feature_convenience_API branch January 21, 2021 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for URL instead of NSURL
1 participant