Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to use SFTP server #116

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adriaat
Copy link
Contributor

@adriaat adriaat commented Feb 29, 2024

  • Have you added unit tests for the new functionality?
  • Have all tests passed in your local clone?
  • Have you written documentation that is easy to understand?
  • Have you added an example?
  • Has the formatting of your code been checked?

Addresses #115. I only tested that we can download files with the upcoming change from ICARE. Finding files by day did not work with the previous code (maybe I was doing something wrong?!). I did not bother to fix more as I am aware of the ongoing refactoring.

Also, I had to install beautifulsoup4 in a clean environment to add the identity and download a test file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant