Implement remaining SFML 2.6.0 changes

[ChrisThrasher]

Credit to @dogunbound for this list from PR #186. I'm moving this list out to its own issue so we can track these changes while we incrementally merge PRs.

---

Basically, we need to slowly go through EVERY pull request and see if any change needs to be made and make those changes. If there aren't any changes needed for a specific pull request, mark it as complete.
todo list:

• Fix RPATH for installed examples on Linux SFML#1477
• Android: don't force installation prefix SFML#1509
• SFML not honoring CMAKE_INSTALL_PREFIX SFML#1561
• Use GNUInstallDirs in CMake for install flexibility SFML#1563
• Use GNUInstallDirs module for cmake install paths SFML#1576
• Fix CMake scripts to install and find doxygen's generated SFML.tag file SFML#1624
• Update CMake minimum version to 3.7.2 SFML#1739
• Fix test and example incompatibility with ARM Macs SFML#1960
• Fixed example documentation to match the code SFML#1519
• Documentation misleading concerning the order when combining transforms SFML#1608
• Improve sf::Transform documentation SFML#1628
• Question: Can sf::TcpListener pick a random available port? SFML#1657
• Added missing documentation about TcpListener::listen and Socket::AnyPort SFML#1658
• Doc builds index.html with invalid link to "annotated.php" SFML#1652
• Remove link in documentation main page SFML#1665
• replace dead link in Config.hpp file SFML#1697
• Bug on the sfml site SFML#1774
• Add missing semicolon in doc example SFML#1776
• Add missing comment SFML#1853
• Add warning about XButton1 and 2 on X11. SFML#2038
• corrected/clarified the setLoopPoints() documentation SFML#2083
• Document that checking XButton1 and XButton2 state on X11 is not supported SFML#2271
• Fix cast SFML#1499
• Removed useless cast SFML#1553
• Fixes compilation error on MacOS SFML#2040
• Fix minor inconsistency in type cast in voip example SFML#2222
• Fix Clang warnings in DRM code SFML#2297
• Replace c-style casts & fix implicit conversion warnings in DRM code SFML#2298
• Backport macOS + Clang compiler error fix SFML#2323
• Include Unit Tests SFML#623
• Add unit testing foundation to SFML SFML#1475
• Variable / Function comments not shown in Intellisense SFML#1622
• Changed Doxygen single-line comment format SFML#1623
• Add Github Actions. SFML#1716
• Change GitHub Actions failure mode SFML#1751
• Update GitHub Actions VS Workers SFML#2058
• Disable warnings as errors for clang-cl builds SFML#2114
• NetBSD support SFML#1535
• NetBSD support proposal. SFML#1723
• Slight increase performance and code refactor SFML#1732
• Non-free stuff in dist tar ball SFML#1627
• Use public domain resources for examples. SFML#1718
• Added CPack definitions and an NSIS template for easy packaging SFML#1114
• Add support for SFML unity builds SFML#1787
• Enable support for unity builds SFML#1788
• Fix useless temporary sf::Lock SFML#1848
• Remove some include directives for unused headers SFML#1849
• Fix typo in variable name in Unix/JoystickImpl.cpp SFML#2219
• Fix SoundRecorder example code SFML#2220
• Include InputStream.hpp directly in SoundFileReaderMp3.cpp SFML#2221
• Fix compile on linux with gcc 12.2.0 SFML#2241
• Minor warnings to fix (-Wunused-parameter, -Wsign-compare) SFML#1785
• Fix several unused warnings SFML#1791
• Fix several unused warnings (continued) SFML#1846
• Fix regression in shader example SFML#1906
• Fix warnings for clang SFML#1908
• Fix -Wmissing-braces warning under clang (for SFML 2.6) SFML#2048
• sf::cursor.loadFromPixels doesn't work. SFML#2066
• Fix incorrect cast in Cursor::loadFromPixels Unix implementation SFML#2073
• Fix incorrect cast when loading 16-bit samples from WAV file SFML#2094
• 2.6.x Build fails with GCC 12.1.0 (Arch Linux) SFML#2100
• bugfix for #2100: null-dereference in GCC 12.1.0 SFML#2106
• Fix incorrect cast when parsing FTP connection port SFML#2142
• Compiler warning in Http class SFML#2217
• Use iterator and correct string insert SFML#2218
• Feature request: adding search button to doxygen API site SFML#1841
• Set Doxygen 'SEARCHENGINE' to 'YES' SFML#1940
• Update doxygen configuration and enable searchbar SFML#2173
• Update Search in the Doxygen Documentation SFML#2477
• Problems with building SFML 3 (and 2.6) on Windows with Clang SFML#2046
• Lock 2.6.x branch to macOS 11 images SFML#2263
• Fix Clang build on Windows SFML#2294
• Configure doxygen STRIP_FROM_INC_PATH option SFML#2512
• MacOS CMake Rejects arm64 arch SFML#1749
• macOS: allow CMAKE_OSX_ARCHITECTURES to be arm64 SFML#1750
• Add support for arm64 on macOS SFML#1761
• Use correct rpath value for dependencies SFML#1843
• Let CMake autodetect Apple arch on M1 processor SFML#1868
• [iOS] Have OpenGL, Window and Pong examples build and run SFML#1418
• iOS example support SFML#1520
• iOS example updates SFML#1522
• fix(compilation): clang compilation on windows SFML#1612
• Add apt-get update command for the CI SFML#1720
• Building with Clang under a MinGW environment fails SFML#1784
• Fix configuration conflicts with Clang SFML#1795
• Update stb_image (2.16 -> 2.26) and stb_image_write (1.07 -> 1.15) SFML#1712
• windows: add resource.rc files to dll builds SFML#1419
• windows: add resource.rc files to dll builds SFML#1779
• Build fails for arm64-v8a SFML#1648
• Added 64bit libraries for Android SFML#2165
• Fixed unable to build SFML with latest Android NDK SFML#1575
• Copy logo.png to Resources in Cocoa example SFML#1818
• Add support for Visual Studio 2022 SFML#1819
• Recompile with -fPIC on Android x86 SFML#2393
• Build sfml-main with position-independent code SFML#2397
• Simplify management of ActivityStates SFML#1845
• sf::Clock restart() returns negative values in continuous work SFML#1765
• Fix overflow when using sf::Clock for long time SFML#1771
• Allow creation of a window without an OpenGL context SFML#1484
• Fixing issue with already defined targets, silently return SFML#1539
• Fixed CMake configuration issue with EGL and GLES and wrong include header order for EGL SFML#1577
• Dynamically load EGL and GLES extensions as is done for desktop GL SFML#1603
• Dynamically load EGL with glad on Linux (DRM) SFML#2157
• Fix compilation on Linux with SFML_OPENGL_ES option SFML#2160
• Add support for creating Vulkan window surfaces. SFML#1557
• Scancode SFML#1235
• Initial X11 scancode implementation SFML#1400
• Numpad Dot not in documentation. SFML#1596
• Fixes for X11 scancode implementation SFML#2009
• Fixes for Windows scancode implementation SFML#2096
• Add empty scancode implementation for Linux (DRM) platform SFML#2148
• Fixes for macOS scancode implementation SFML#2243
• Allow setting cursors with colors on Linux SFML#1693
• Add support for colored cursors in Unix implementation SFML#1694
• Added support for directional arrow resize cursors on Linux SFML#1688
• Input method support on Linux SFML#1840
• X11: fix XIM input method support SFML#1850
• Key Released event is either not properly ordered or missing when fps is limited SFML#2191
• Fix order and remove duplicates of KeyPressed events SFML#2242
• DRM/KMS Implementation SFML#2029
• Fix eglCheck macro usage for assignments SFML#2146
• Fix DRM using the first possible video card without even checking if a monitor is connected SFML#2246
• Add DRM sources to sfml-window SFML#2259
• Support installing with static libraries and DRM backend SFML#2400
• Use Per Monitor Aware instead of System Aware for DPI scaling on Windows SFML#2268
• Fix sf::Context::getActiveContext to stop returning inactive contexts SFML#1794
• Crashes when $DISPLAY isn't :0.0 SFML#724
• Unix: Filter X visual by X screen SFML#1504
• EGl Context EGL_BAD_SURFACE issue when pausing and resuming app and solution SFML#1530
• Make sure setActive(false) is called before the surface is destroyed in EglContext. SFML#1531
• EGL Context antialiasing bug  SFML#1533
• Fixed EGL incorrectly being passed the anti-aliasing level as EGL_SAMPLE_BUFFERS instead of EGL_SAMPLES. SFML#1534
• Fix OpenGL extensions not always loading SFML#1495
• Fix OpenGL extensions not loading SFML#1543
• Very minor bug in Window\Win32\WglContext.cpp SFML#1245
• Fixed potential buffer overrun in Win32 OpenGL error handling SFML#1246
• A hidden mouse cursor doesn't re-appear when hovering the title bar SFML#1569
• Fix: Win32 no longer hides cursor when hovering title bar. SFML#1570
• High value for Window antialiasingLevel causes frequent segfaults on macOS SFML#1582
• Initialise m_context correctly in SFContext constructors SFML#1610
• Android: Set SYSTEM_UI_FLAG_HIDE_NAVIGATION when going to Fullscreen … SFML#1538
• Fixed navigation bar not being entirely hidden on Android SFML#1554
• Make the process to set a DirectInput device's axis mode more conservative SFML#1634
• Added XFlush call to WindowImplX11::setMouseCursor SFML#1686
• Fixed joystick POV values not being set properly for devices that are… SFML#1719
• Fix warning: control may reach end of non-void function [-Wreturn-type] SFML#1713
• Fixed Win32 requestFocus in multithreaded environment SFML#1600
• eglGetDisplay is NULL on Android SFML#1639
• Fix NULL in Android EGL_DEFAULT_DISPLAY SFML#1740
• MacOS: When initializing an openGL view with an existing window, call finishInit SFML#1759
• MacOS: When initializing an openGL view with an existing window, call finishInit SFML#1760
• Retain cursor if an unsupported cursor is used SFML#1721
• Fix potential crash when changing cursor - don't release the NSCursor object if it's already been released SFML#1736
• Android Screen rotation crash SFML#531
• Fixed SIGSEGV after pressing back button on Android SFML#1580
• Android Window waitEvent issues with OpenGL Context SFML#1532
• Fix OpenGL context on Android SFML#1790
• OpenGL failing to init properly on iOS SFML#1687
• Try more possible names for OpenGLES library. SFML#1804
• Fullscreen leaves zombie window open on macOS SFML#1581
• Process Cocoa events after window close SFML#1814
• Preserve the drop shadow for system cursors on Windows SFML#1731
• Fixed funcs for safe use in Win32/Win64 SFML#1806
• Crash after closing wxWidgets with SFML-window SFML#1549
• Ensure proper nesting of autorelease pools on OS X SFML#1820
• Error in WindowImplX11.cpp SFML#1951
• Fix constructor typo in Unix/X11 SFML#1953
• Linux: Crash when creating window if more than 1024 file descriptors are open SFML#1900
• Prevent crash in Unix JoystickImpl with too many file descriptors SFML#1941
• [macOS] Core context support for OpenGL >3.30 SFML#1434
• Allow re-creation of the shared context as a core context SFML#1443
• Added getPosition() and getSize() to sf::Rect<T>. SFML#1047
• Added Font::hasGlyph field SFML#1644
• sf::Image::saveToMemory SFML#988
• Implemented saveToMemory and saveImageToMemory. SFML#1597
• Implemented saveToMemory and saveImageToMemory. SFML#1669
• Implement smoothing for fonts SFML#1690
• Fix setSmooth(false) not having an effect before first text drawcall SFML#2064
• Fix font pages not being created with the desired smoothness SFML#2072
• Suggestion: Min and Max blend Equations SFML#1710
• Add Min and Max blend modes SFML#1756
• linux mesa driver and geometry shader SFML#1768
• Support geometry shaders when a OpenGL 3.2+ context is available SFML#1769
• OpenGL extension SGIS_texture_edge_clamp unavailable SFML#1786
• Fixed regression introduced in 4fcef89 causing EXT_texture_edge_clamp support to not be considered SFML#1789
• Use wide-string character consistently SFML#2107
• Update stb_image (2.16 -> 2.26) and stb_image_write (1.07 -> 1.15) SFML#1712
• Update stb_image and Image documentation SFML#2322
• Upgrade to stb_image 2.28 SFML#2464
• Idea to improve high DPI handling on OS X SFML#1817
• assert in src/SFML/graphics/text.cpp SFML#1558
• Fixed missing checks for empty vertex arrays when updating the vertex buffers in sf::Text. SFML#1560
• Remove unnecessary glFlush() SFML#1609
• Fixed text rendering artifacts on Radeon cards. SFML#1568
• Empty RenderTexture after recreating window SFML#1625
• Force OpenGL states to be reset when RenderTarget detects that a new context has to be tracked. SFML#1630
• [sprite] don't set default rect before the user provided one SFML#1725
• Changes to text kerning -- auto-hinting compensation SFML#1745
• Added auto hinting compensation to fix too wide gaps between small glyphs SFML#1746
• Drawing to RenderTexture with sRGB conversion enabled results in banded colors SFML#1092
• Support sRGB color space in RenderTexture SFML#1757
• Incorrect glyph position with text outline SFML#1826
• Fix incorrect glyph rect for text outline SFML#1827
• Fixed text underline and strike-through missing outline SFML#1836
• sf::Image::copy() - Fixed the incorrect alpha value being calculated for semi-transparent pixels on fully transparent pixels SFML#1993
• sf::Text::getLocalBounds() inconsistency SFML#2129
• Fix corelation between text setOutlineThickness() and getLocalBounds() SFML#2132
• iOS apps just show as a blank magenta screen SFML#1471
• Ensure the proper default framebuffer is bound when activating a Rend… SFML#1487
• allow for closing sound files SFML#1516
• Remove usages of std::auto_ptr to get rid of warnings when building with gcc 8.2 SFML#1546
• Allow changing processing interval in SoundStream SFML#1517
• Adjustable processing interval in SoundStream #1517 SFML#1666
• Fix sf::Music sometimes failing to loop after seeking SFML#1707
• Add support for MP3 SFML#1232
• MP3 reader support SFML#1796
• MP3 reader support using minimp3 SFML#1851
• find_package(Vorbis REQUIRED) fail quietly SFML#1626
• Rename FindVorbis -> FindVORBIS, for consistency with exported variab… SFML#1629
• Lowercase Vorbis in SFMLConfigDependencies.cmake.in: set_property could not find TARGET Vorbis. SFML#1636
• SFMLConfigDependencies.cmake.in: Vorbis uppercase (fixes #1636) SFML#1637
• Fixed copy assign operator in sf::Sound so it checks for self-assignment SFML#1744
• Fix SoundStream::play to restart the sound if it was played before SFML#2175
• Added method to get the current read position to sf::Packet. SFML#1382
• Added method to get the current read position of sf::Packet SFML#1641
• Sometimes not able to receive floats via Packet on Android SFML#1565
• Fixed sometimes failing to read floats and doubles from Packet on Android. SFML#1578

[ChrisThrasher]

The most work lies in the SFML patches that add new features so I'll try to list them out here. This should make it easier to understand what work remains and start delegating that to those who volunteer. This is mostly just an inverse of the above list.

I'm checking off items as soon as a PR to fix them is open. After that the PRs themselves will track our progress.

• Allow creation of a window without an OpenGL context SFML#1484
• Add support for creating Vulkan window surfaces. SFML#1557
• Scancode SFML#1235
• Add support for colored cursors in Unix implementation SFML#1694
• Added support for directional arrow resize cursors on Linux SFML#1688
• DRM/KMS Implementation SFML#2029
• Added getPosition() and getSize() to sf::Rect<T>. SFML#1047
• Implemented saveToMemory and saveImageToMemory. SFML#1669
• Add Min and Max blend modes SFML#1756
• Added auto hinting compensation to fix too wide gaps between small glyphs SFML#1746
• Support sRGB color space in RenderTexture SFML#1757
• Adjustable processing interval in SoundStream #1517 SFML#1666 (no changes required)
• MP3 reader support using minimp3 SFML#1851

[shane-tran-whitmire]

I would Highly recommend you put up a draft Pull request of the one you are working on, so others don't accidentally "take" yours.

[ChrisThrasher]

Dibs on SFML/SFML#1047

See PR #190

[ChrisThrasher]

See PR #191

[dogunbound]

Dibs on SFML/SFML#1746

I'll set up a PR later and update this comment with said PR number. I also just realized you can't really make a PR without a change, so calling dibs here first would be best.

#192

[ChrisThrasher]

Dibs on SFML/SFML#1851

#193

[ChrisThrasher]

Dibs on SFML/SFML#1688

#194

[ChrisThrasher]

Dibs on SFML/SFML#1669

#195

[ChrisThrasher]

Dibs on SFML/SFML#1757

#196

[ChrisThrasher]

I'm marking SFML/SFML#1666 as complete since using sf::SoundStream::setProcessingInterval requires inheriting from sf::SoundStream and since that is not something we can express in the C interface, I'm not sure it makes sense to add that to CSFML. I suppose we could make a function called sfSoundStream_setProcessingInterval but then we're taking a protected function and basically making it public which doesn't seem quite right.

I also considered adding it to sfMusic but protected member functions can never be promoted to public member functions so this is not something we can call on an instance of sf::Music and thus compilation fails.

[ChrisThrasher]

Dibs on SFML/SFML#1235

#197

[ChrisThrasher]

Dibs on #SFML/SFML#1557

#198

[shane-tran-whitmire]

I think it's ok to make protected member variables public in this case. We need to look for another instance of this to really know what we should do though.

[dogunbound]

I think I missed taking SFML/SFML#1788 off the needed changes list. @ChrisThrasher could you update that list and check this one off?

Edit: Oh i see the mini list you created.

[ChrisThrasher]

See #207 for an implementation of SFML/SFML#1484

Last 2.6.0 feature! 🥳

[ChrisThrasher]

All done!!

[svenstaro]

How about a new CSFML release with these changes?