Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement isSrgb() #196

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Implement isSrgb() #196

merged 1 commit into from
Jul 7, 2023

Conversation

ChrisThrasher
Copy link
Member

Implements SFML/SFML#1757

@ChrisThrasher ChrisThrasher requested a review from eXpl0it3r July 4, 2023 23:21
@ChrisThrasher ChrisThrasher mentioned this pull request Jul 4, 2023
Closed
shane-tran-whitmire
shane-tran-whitmire approved these changes Jul 5, 2023
View reviewed changes
Copy link

@shane-tran-whitmire shane-tran-whitmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my work account. You can consider this a regular approval

@dogunbound dogunbound mentioned this pull request Jul 6, 2023
Open
6 tasks
kimci86
kimci86 reviewed Jul 6, 2023
View reviewed changes
Copy link
Contributor

@kimci86 kimci86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small remarks on documentation. Applies to both RenderTexture and RenderWindow headers.

include/SFML/Graphics/RenderTexture.h Outdated Show resolved Hide resolved
include/SFML/Graphics/RenderTexture.h Outdated Show resolved Hide resolved
include/SFML/Graphics/RenderTexture.h Outdated Show resolved Hide resolved
eXpl0it3r
eXpl0it3r requested changes Jul 6, 2023
View reviewed changes
include/SFML/Graphics/RenderWindow.h Outdated Show resolved Hide resolved
@ChrisThrasher ChrisThrasher requested a review from eXpl0it3r July 6, 2023 22:50
@ChrisThrasher ChrisThrasher merged commit 920ff4d into master Jul 7, 2023
@ChrisThrasher ChrisThrasher deleted the srgb_color branch July 7, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimci86 kimci86 kimci86 approved these changes

@eXpl0it3r eXpl0it3r eXpl0it3r approved these changes

@shane-tran-whitmire shane-tran-whitmire shane-tran-whitmire approved these changes

Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChrisThrasher @eXpl0it3r @kimci86 @shane-tran-whitmire