Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #1602 from heinezen/clang-format-align" #1605

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

heinezen
Copy link
Member

Currently, using BlockIndent can reformat other parts of the code to something less readable, e.g.

void WorldRenderEntity::update(const uint32_t ref_id,
                               const curve::Continuous<coord::phys3> &position,
                               const curve::Segmented<coord::phys_angle_t> &angle,
                               const std::string animation_path,
                               const time::time_t time)

to

void WorldRenderEntity::update(const uint32_t ref_id, const curve::Continuous<coord::phys3> &position, const curve::Segmented<coord::phys_angle_t> &angle, const std::string animation_path, const time::time_t time)

This is not really great for readability, so I would switch back to the old style until we or clang-format has a solution for this.

@heinezen heinezen added the code quality Does not alter behavior, but beauty of our code label Nov 27, 2023
…ign"

This reverts commit bfa99b5, reversing
changes made to 4334fff.
@TheJJ TheJJ merged commit 2391847 into SFTtech:master Nov 30, 2023
12 of 13 checks passed
@heinezen heinezen deleted the fix/revert_clang_format branch December 25, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Does not alter behavior, but beauty of our code
Projects
Development

Successfully merging this pull request may close these issues.

2 participants