Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate flow field pathfinder into game simulation #1656

Merged
merged 68 commits into from
Oct 31, 2024
Merged

Integrate flow field pathfinder into game simulation #1656

merged 68 commits into from
Oct 31, 2024

Conversation

heinezen
Copy link
Member

@heinezen heinezen commented Jun 2, 2024 •
edited
Loading

Makes the pathfinder usable from the game simulation.

Depends on #1648, #1647

Introduces several additions and optimizations to the work started in #1620 :

  • Flow field documentation
  • Gamestate
    • Map object for accessing pathfinder
    • use pathfinder in move system
    • new nyan API bindings for Terrain objects
  • Pathfinder
    • Massive performance increase for flow field calculation
    • LOS propagation across sectors
    • Flow field caching
    • Fixed several bugs

@heinezen heinezen added improvement Enhancement of an existing component lang: c++ Done in C++ code area: simulation Involved in the game mechanics and simulation big stuff High-impact changes, mainly foundation work labels Jun 2, 2024
@heinezen heinezen changed the title Feature/gamestate pathing Integrate flow field pathfinder into game simulation Jun 2, 2024
TheJJ

This comment was marked as duplicate.

Sign in to view

@heinezen heinezen mentioned this pull request Jul 12, 2024
Merged
13 tasks
C3pa
C3pa reviewed Jul 27, 2024
View reviewed changes
libopenage/gamestate/map.cpp Outdated Show resolved Hide resolved
@heinezen heinezen force-pushed the feature/gamestate-pathing branch 2 times, most recently from 7809d09 to 1487ef3 Compare July 28, 2024 01:38
@heinezen heinezen marked this pull request as ready for review July 28, 2024 01:38
@heinezen heinezen added this to the 0.6.0 milestone Jul 28, 2024
@heinezen heinezen force-pushed the feature/gamestate-pathing branch 2 times, most recently from c0bfe1f to da96a11 Compare July 28, 2024 11:21
@heinezen heinezen added the kevin-rebuild-pl0x instruct kevin to rebuild this pull request label Jul 28, 2024
@SFTbot SFTbot removed the kevin-rebuild-pl0x instruct kevin to rebuild this pull request label Jul 28, 2024
@TheJJ TheJJ added the kevin-rebuild-pl0x instruct kevin to rebuild this pull request label Jul 30, 2024
@SFTbot SFTbot removed the kevin-rebuild-pl0x instruct kevin to rebuild this pull request label Jul 30, 2024
@heinezen heinezen force-pushed the feature/gamestate-pathing branch 2 times, most recently from abce704 to 13ce00c Compare August 2, 2024 14:31
@heinezen
path: Align bit positions for shared flags of flow/integration cell v…
7a48ef0 
…alues.
@heinezen
path: Use integration flags in flow field shader.
9f4355c
@heinezen
path: Remove FLOW_WAVEFRONT_BLOCKED flag.
4f843d8
@heinezen
path: Add FLOW_TARGET flag.
7b71179
@heinezen
path: Check ifr target cell has been reached using flow target flag.
82ce34e
@heinezen
etc: Add unused placeholders for integration flags.
c1d5637
@heinezen
path: Optimize performance-critical paths in the code.
9206916
@heinezen
path: Remopve outdated TODOs.
2ac9638
@heinezen
path: Fix existing unit tests.
a7415ab
@heinezen
path: More helpful log messages.
2abbb3d
@heinezen
path: Fix waypoint finder exiting one cell too early.
09e22df
@heinezen
Fix compiler warnings.
b651e36
@heinezen
path: Vectorize and unroll loops to maximize performance.
3790ffb
@heinezen
path: Speed up flow field access.
91e84a9
@heinezen
path: Optimize portal exit node search for speed.
156165a
@heinezen
path: Optimize access to integration cell in LOS pass.
7eaebae
@heinezen
path: Make distinction between cardinal/diagonal checks more clear.
3a63dc6
@heinezen
etc: Remove pathfinding TODO from pretty printer.
498beb3
@heinezen
path: Check if target cell is impassable.
9662186
@heinezen
renderer: Update animation frame based on keyframe insertion time.
38d05e6
@heinezen
gamestate: Do not spawn entities outside of map area.
7032505
@heinezen
doc: Document field types in flow field pathfinder.
e999fe4
@heinezen
gamestate: Use nyan terrain definition for modpacks without terrain g…
3c79d9e 
…raphics.
@heinezen
presenter: Let camera look at map center on startup.
347d586
@heinezen heinezen mentioned this pull request Aug 25, 2024
Open
4 tasks
@heinezen heinezen mentioned this pull request Sep 27, 2024
Open
5 tasks
TheJJ
TheJJ approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@TheJJ TheJJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is good for now, and an incremental improvement to the already well designed previous code. we surely can improve further and fix bugs that show up in practice :)

libopenage/gamestate/api/terrain.cpp
const std::unordered_map<nyan::fqon_t, int> APITerrain::get_path_costs(const nyan::Object &terrain) {
std::unordered_map<nyan::fqon_t, int> result;

nyan::dict_t path_costs = terrain.get_dict("Terrain.path_costs");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be awesome if nyan could return the casted std unordered/map directly...

@TheJJ TheJJ merged commit 00b7f4c into SFTtech:master Oct 31, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C3pa C3pa C3pa left review comments

@TheJJ TheJJ TheJJ approved these changes

Assignees
No one assigned
Labels
area: simulation Involved in the game mechanics and simulation big stuff High-impact changes, mainly foundation work improvement Enhancement of an existing component lang: c++ Done in C++ code
Projects
openage game simulation
Status: ✅ Done
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@heinezen @TheJJ @C3pa @SFTbot