Added sin, cos, and tan operations to fixed point implementation #1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jere8184
reviewed
Feb 17, 2025
copying.md
Outdated
| | Michael Lynch | mtlynch | git à mtlynch dawt io | | ||
| | Ngô Xuân Minh | | xminh dawt ngo dawt 00 à gmail dawt com | | ||
| | Haytham Tang | haytham918 | yunxuant à umich dawt edu | | ||
| | Ana Trias-Labellarte | anatriaslabella | ana.triaslabella@ufl.edu | |
There was a problem hiding this comment.
shouldn't your email be in the same format as the others?
There was a problem hiding this comment.
Just fixed it and committed it, thank you! Not sure why the rest of the table format is not passing certain checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a first-time open source contributor, I decided to try implementing additional fixed-point math operTations that were requested that may be nice to see, specifically the trigonometric operations sin, cos, and tan. I hope my code is sufficient to solve this issue!