S2S_added sample after sharing a case/contact does not get shared [2]

[SahaLinaPrueger]

Bug Description

Added sample after sharing a case/contact does not get shared.

Steps to Reproduce

1. Create a case/ contact in source system
2. Add a Sample
3. Share case/contact to target system
4. Add another sample in source system
5. Accept case/contact in target system
6. Check if both samples are visible in target system
7. Currently just one sample is visible in target system
8. Check if both samples are visible in source system
9. Currently both samples are visible in source system

-> tested with different combinations of dates -> no difference, both samples are never visible in target system
-> with vaccinations everything is fine and works

Expected Behavior

Both samples should also be visible in target system

Screenshots

source system:

target system:

System Details

• Device: Windows 11
• SORMAS version: 1.73.1
• Android version/Browser: Edge
• Server URL: release-sormas-x / release-de
• User Role: admin

Additional Information

[SahaLinaPrueger]

@JaquM-HZI

[leventegal-she]

The second sample is not shared because it was added after the share request has been sent and the share request on the target system doesn't contain the new sample.
The same thing happens when you share case with contacts.

I'm not sure it's would be ok share more data then the accepted request contains.

To send also the second sample a new share request needs to be sent.

I don't consider this to be a bug. We would need a change request for changing this behaviour.

[SahaLinaPrueger]

The current situation means that neither the target system can see the sample, nor the source system can edit or view the sample. For Vaccination everything works as it should. The shared elements should be synchronised on both sides.
After the target system accepts the share request, the target system can add samples and the added samples are sync to the source system. Only the added sample while the status of the share request was 'pending' does not appear in the target system.
I consider this is a bug.

I'm not sure it's would be ok share more data then the accepted request contains. The status of the share request is pending. As long as the target system has not accepted the share request, it is ok.

To send also the second sample a new share request needs to be sent. If it can technically only be solved in this way, the share request must be revoked in the background and a new share request must be sent automatically in the background. There must be no additional effort for the user.

[StefanKock]

Moved out of 1.74 and to be discussed.

[markusmann-vg]

@leventegal-she
According to @JaquM-HZI it should be implemented as described and therefore it's a change
We'll discuss it in the refinement and estimate the effort

[AndyBakcsy-she]

Validated ticket on a peer-testing session with Levi

[StefanKock]

Reported by @fhauptmann: Deployment on test-de1 and test-de2 not working:

Updating database to version 477... (de.symeda.sormas.backend.common.StartupShutdownService.java:738)
ERROR: column "datatype" contains null values

  A system exception occurred during an invocation on EJB UpdateQueryTransactionWrapper, method: public int de.symeda.sormas.backend.common.StartupShutdownService$UpdateQueryTransactionWrapper.executeUpdate(de.symeda.sormas.backend.common.StartupShutdownService$UpdateQueryTransactionWrapper$TargetDb,java.lang.String)]]
sormas_1             |
[2022-08-01T10:32:12.203+0200] [Payara 5.2021.10] [WARNUNG] [] [javax.enterprise.ejb.container] [tid: _ThreadID=114 _ThreadName=payara-executor-service-scheduled-task] [timeMillis: 1659342732203] [levelValue: 900] [[
sormas_1             |
javax.ejb.EJBException: org.hibernate.exception.ConstraintViolationException: could not execute statement
...
 at com.sun.proxy.$Proxy1141.executeUpdate(Unknown Source)
 at de.symeda.sormas.backend.common.__EJB31_Generated__StartupShutdownService$UpdateQueryTransactionWrapper__Intf____Bean__.executeUpdate(Unknown Source)
 at de.symeda.sormas.backend.common.StartupShutdownService.updateDatabase(StartupShutdownService.java:739)
 at de.symeda.sormas.backend.common.StartupShutdownService.startup(StartupShutdownService.java:207)
 at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
...
 at org.hibernate.query.internal.AbstractProducedQuery.executeUpdate(AbstractProducedQuery.java:1696)
 ... 133 more
Caused by: org.postgresql.util.PSQLException: ERROR: column "datatype" contains null values
 at org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2675)
...
 at org.hibernate.engine.jdbc.internal.ResultSetReturnImpl.executeUpdate(ResultSetReturnImpl.java:197)
 ... 137 more
]]