Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9771 S2S_added sample after sharing a case/contact does not get shared - fixed failing migration #10006

Conversation

leventegal-she
Copy link
Contributor

Fixes #9771

@leventegal-she leventegal-she requested a review from JonasCir August 1, 2022 10:11
@JonasCir
Copy link
Contributor

JonasCir commented Aug 1, 2022

@leventegal-she There is a CI failure. I'm not certain what this change does, how can you have a share without attached object?

if this is fixing the migration, I would just give this a green light after the tests are passing?

@leventegal-she
Copy link
Contributor Author

leventegal-she commented Aug 1, 2022

@leventegal-she There is a CI failure. I'm not certain what this change does, how can you have a share without attached object?

if this is fixing the migration, I would just give this a green light after the tests are passing?

This fixes the migration issue "ERROR: column "datatype" contains null values"

The CI failure is because of the wrong commit on the development. I will update this PR after the dev is fixed and wait for the CI to succeed.

…ation_S2S_added_sample_after_sharing_a_case/contact_does_not_get_shared
@leventegal-she leventegal-she merged commit 5e4bd0d into development Aug 1, 2022
@leventegal-she leventegal-she deleted the #9771_fix_migration_S2S_added_sample_after_sharing_a_case/contact_does_not_get_shared branch August 1, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S2S_added sample after sharing a case/contact does not get shared [2]
2 participants