Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual Studio 2019 compilation error ('SQLite::Database::Database': delegating constructor calls itself) #317 #318

Merged
merged 3 commits into from
Jan 9, 2021
Merged

Visual Studio 2019 compilation error ('SQLite::Database::Database': delegating constructor calls itself) #317 #318

merged 3 commits into from
Jan 9, 2021

Conversation

chronoxor
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jan 6, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling f01d77d on chronoxor:master into ef650e0 on SRombauts:master.

@SRombauts
Copy link
Owner

Hi, thanks but it means you are disabling this new constructor for vs2017 as well...
Would be better to have a proper fix

@SRombauts SRombauts mentioned this pull request Jan 6, 2021
Merged
@Chronial
Copy link

Chronial commented Jan 8, 2021

I created an alternative fix in #319

@SRombauts SRombauts merged commit 114f89d into SRombauts:master Jan 9, 2021
@Chronial Chronial mentioned this pull request Jan 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chronoxor @coveralls @SRombauts @Chronial