Fix std::filesystem::path Database constructor (fixes #317) #319
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return type of
path.c_str()
is platform-dependent and is awstring
on windows.path.u8string()
always returns an utf8-encoded string.In c++17, that string has type
std::string
, but starting in c++20 it isstd::u8string
. I used a reinterpret_cast to handle the c++20 case.Alternatively, a constructor taking u8string could be added for the c++20 case. But it seems odd to have only one place where the library accepts u8strings. If support for u8strings is added, it should probably be done for the whole library at once.