Clean up to prepare for test script refactor #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinnlangille
approved these changes
Nov 27, 2018
quinnlangille
pushed a commit
that referenced
this pull request
Dec 19, 2018
* fix(precommit): use jest exit code * fix(jest): restore coverage collection context * chore(package.json): remove phased out test tools
VojtechKlos
pushed a commit
to Symphony9/vue-carousel
that referenced
this pull request
Dec 20, 2018
* fix(precommit): use jest exit code * fix(jest): restore coverage collection context * chore(package.json): remove phased out test tools
quinnlangille
pushed a commit
that referenced
this pull request
Dec 20, 2018
* Clean up to prepare for test script refactor (#330) * fix(precommit): use jest exit code * fix(jest): restore coverage collection context * chore(package.json): remove phased out test tools * style(eslint): commit eslint fixes (#336) * feat: add watcher to Autoplay Prop (#344) * fix(carousel): flush the slides left when they don't fill the width (#323) * fix(carousel): Flush the slides left when they don't fill the width (#323) When there are too few slides to fill the row, with scrollPerPage, the slides were flushed right instead of left. By bounding maxOffest to a minimum of 0, the slides are aligned on the left-hand-side Fix #323 * style(play): Use capitals in tests for consistency * v0.16.1 * chore: build * feat(standard): watch autoplay prop and enable/disable autoplay * feat(pagination) added an option to add custom title in pagination buttons * updated test snapshots * fixed wrong conflict resolution of carousel.vue
quinnlangille
pushed a commit
that referenced
this pull request
Dec 27, 2018
* fix(precommit): use jest exit code * fix(jest): restore coverage collection context * chore(package.json): remove phased out test tools
quinnlangille
pushed a commit
that referenced
this pull request
Dec 27, 2018
* Clean up to prepare for test script refactor (#330) * fix(precommit): use jest exit code * fix(jest): restore coverage collection context * chore(package.json): remove phased out test tools * style(eslint): commit eslint fixes (#336) * feat: add watcher to Autoplay Prop (#344) * fix(carousel): flush the slides left when they don't fill the width (#323) * fix(carousel): Flush the slides left when they don't fill the width (#323) When there are too few slides to fill the row, with scrollPerPage, the slides were flushed right instead of left. By bounding maxOffest to a minimum of 0, the slides are aligned on the left-hand-side Fix #323 * style(play): Use capitals in tests for consistency * v0.16.1 * chore: build * feat(standard): watch autoplay prop and enable/disable autoplay * feat(pagination) added an option to add custom title in pagination buttons * updated test snapshots * fixed wrong conflict resolution of carousel.vue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix(precommit): use jest exit codeRemove
--forceExitflag so precommit can use jest's exit code instead of failing the check all the time.fix(jest): restore coverage collection contextJest initialize the
rootDirto the directory of the loaded config file instead of project root so specifyingrootDirto the project root will fix coverage collection context.https://coveralls.io/builds/20303864
chore(package.json): remove phased out test toolsmocha,chai,sinon,sinon-chaiare no longer needed with the introduction ofjestwhich will be the test framework used moving forward.Motivation and Context
In attempt to increasing code coverage (#143), these are the necessary preparation towards the goal.
How Has This Been Tested?
All commands below ran without error.
Screenshots (if appropriate):
N/A
Types of changes
New feature (non-breaking change which adds functionality)Breaking change (fix or feature that would cause existing functionality to not work as expected)Checklist:
My code follows the code style of this project.My change requires a change to the documentation.I have updated the documentation accordingly.I have included a vue-play example (if this is a new feature)