Watch Autoplay Prop #344
Merged
Watch Autoplay Prop #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…323) * fix(carousel): Flush the slides left when they don't fill the width (#323) When there are too few slides to fill the row, with scrollPerPage, the slides were flushed right instead of left. By bounding maxOffest to a minimum of 0, the slides are aligned on the left-hand-side Fix #323 * style(play): Use capitals in tests for consistency
|
Hey @csmoakpax8, sorry for the delay on reviewing this - we've been wrapping up the year in office and it's been crazy lol. This is a great addition, and IMO should have been part of the original feature. I'll merge it into our v0.17.0 working branch as a feature! Thanks for the contribution |
quinnlangille
pushed a commit
that referenced
this pull request
Dec 19, 2018
* fix(carousel): flush the slides left when they don't fill the width (#323) * fix(carousel): Flush the slides left when they don't fill the width (#323) When there are too few slides to fill the row, with scrollPerPage, the slides were flushed right instead of left. By bounding maxOffest to a minimum of 0, the slides are aligned on the left-hand-side Fix #323 * style(play): Use capitals in tests for consistency * v0.16.1 * chore: build * feat(standard): watch autoplay prop and enable/disable autoplay
|
I understand this feature ship with version 0.17.0? |
|
@gertvdkolk should be early next week! |
VojtechKlos
pushed a commit
to Symphony9/vue-carousel
that referenced
this pull request
Dec 20, 2018
* fix(carousel): flush the slides left when they don't fill the width (SSENSE#323) * fix(carousel): Flush the slides left when they don't fill the width (SSENSE#323) When there are too few slides to fill the row, with scrollPerPage, the slides were flushed right instead of left. By bounding maxOffest to a minimum of 0, the slides are aligned on the left-hand-side Fix SSENSE#323 * style(play): Use capitals in tests for consistency * v0.16.1 * chore: build * feat(standard): watch autoplay prop and enable/disable autoplay
quinnlangille
pushed a commit
that referenced
this pull request
Dec 20, 2018
* Clean up to prepare for test script refactor (#330) * fix(precommit): use jest exit code * fix(jest): restore coverage collection context * chore(package.json): remove phased out test tools * style(eslint): commit eslint fixes (#336) * feat: add watcher to Autoplay Prop (#344) * fix(carousel): flush the slides left when they don't fill the width (#323) * fix(carousel): Flush the slides left when they don't fill the width (#323) When there are too few slides to fill the row, with scrollPerPage, the slides were flushed right instead of left. By bounding maxOffest to a minimum of 0, the slides are aligned on the left-hand-side Fix #323 * style(play): Use capitals in tests for consistency * v0.16.1 * chore: build * feat(standard): watch autoplay prop and enable/disable autoplay * feat(pagination) added an option to add custom title in pagination buttons * updated test snapshots * fixed wrong conflict resolution of carousel.vue
quinnlangille
pushed a commit
that referenced
this pull request
Dec 27, 2018
* fix(carousel): flush the slides left when they don't fill the width (#323) * fix(carousel): Flush the slides left when they don't fill the width (#323) When there are too few slides to fill the row, with scrollPerPage, the slides were flushed right instead of left. By bounding maxOffest to a minimum of 0, the slides are aligned on the left-hand-side Fix #323 * style(play): Use capitals in tests for consistency * v0.16.1 * chore: build * feat(standard): watch autoplay prop and enable/disable autoplay
quinnlangille
pushed a commit
that referenced
this pull request
Dec 27, 2018
* Clean up to prepare for test script refactor (#330) * fix(precommit): use jest exit code * fix(jest): restore coverage collection context * chore(package.json): remove phased out test tools * style(eslint): commit eslint fixes (#336) * feat: add watcher to Autoplay Prop (#344) * fix(carousel): flush the slides left when they don't fill the width (#323) * fix(carousel): Flush the slides left when they don't fill the width (#323) When there are too few slides to fill the row, with scrollPerPage, the slides were flushed right instead of left. By bounding maxOffest to a minimum of 0, the slides are aligned on the left-hand-side Fix #323 * style(play): Use capitals in tests for consistency * v0.16.1 * chore: build * feat(standard): watch autoplay prop and enable/disable autoplay * feat(pagination) added an option to add custom title in pagination buttons * updated test snapshots * fixed wrong conflict resolution of carousel.vue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Watch Autoplay Prop to enable/disable autoplay after initialization.
Motivation and Context
To be able to pause autoplay if the user interacts with any of the slides. The current pause on hover functionality didnt meet my needs.
Fixes/Addresses: #229
How Has This Been Tested?
I added a vue-play example that demonstrates code change.
Types of changes
Checklist: