Correctly publish OIDC redirectUris to Manage #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MKodde
force-pushed
the
bugfix/redirect-uri-formatting
branch
from
d883127
to
9eb59d3
Compare
pablothedude
reviewed
Feb 4, 2019
There was a problem hiding this comment.
Wouldn't it be better if we would also enforce an array instead of a map. Because the problem does not lie in the form because the SaveOidcCommand will always return an array. The problem is the removal of the playground url from the array with redirect uri's in the Entity. If we do so should be also less prone to errors.
MKodde
force-pushed
the
bugfix/redirect-uri-formatting
branch
from
9eb59d3
to
7f1b222
Compare
|
Yes, resetting the data while we are setting it on entity is more elegant. |
The array that is passed along to manage should be a list, not a map. If the php indexes are updated along the way, by adding/removing items from the form. The index order might not be sequentially pristine. This causes JSON encode to generate a map instead of a list. By resetting the list before publishing, this problem should be remedied https://www.pivotaltracker.com/story/show/163646662
MKodde
force-pushed
the
bugfix/redirect-uri-formatting
branch
from
7f1b222
to
771ced8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The array that is passed along to manage should be a list, not a map.
If the php indexes are updated along the way, by adding/removing items
from the form. The index order might not be sequentially pristine. This
causes JSON encode to generate a map instead of a list.
By resetting the list before publishing, this problem should be remedied
https://www.pivotaltracker.com/story/show/163646662