Show motivationless attributes on entity detail #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MKodde
changed the title
MKodde
force-pushed
the
bugfix/show-motivationless-attr-on-entity-detail
branch
from
afa9e4d
to
fd1d701
Compare
The test adds one attribute with motivation and one without to the SURFnet entity. The test then verifies that both are shown. The one with the default, not set text. The latter with the expected attribute motivation that is set on the test entity. See: https://www.pivotaltracker.com/story/show/165597382
Attributes without motivation (possible for drafts and test entities) did not show up on the entity detail screen. They are now displayed. When no motivation is set, a translatable 'no motivation set' message is rendered.
pablothedude
force-pushed
the
bugfix/show-motivationless-attr-on-entity-detail
branch
from
fd1d701
to
746d6dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attributes without motivation (possible for drafts and test entities)
did not show up on the entity detail screen. They are now displayed.
When no motivation is set, a translatable 'no motivation set' message
is rendered.
See: https://www.pivotaltracker.com/story/show/165597382