Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show motivationless attributes on entity detail #255

Merged
merged 2 commits into from
May 16, 2019
Merged

Show motivationless attributes on entity detail #255

merged 2 commits into from
May 16, 2019

Commits on May 16, 2019

  1. Test that attributes without motivation are shown 

    The test adds one attribute with motivation and one without to the
SURFnet entity. The test then verifies that both are shown. The one with
the default, not set text. The latter with the expected attribute
motivation that is set on the test entity.

See: https://www.pivotaltracker.com/story/show/165597382
    @MKodde @pablothedude
    MKodde authored and pablothedude committed May 16, 2019
    Configuration menu
    Copy the full SHA
    921c39f View commit details
    Browse the repository at this point in the history

  2. Show motivationless attributes on entity detail 

    Attributes without motivation (possible for drafts and test entities)
did not show up on the entity detail screen. They are now displayed.
When no motivation is set, a translatable 'no motivation set' message
is rendered.
    @MKodde @pablothedude
    MKodde authored and pablothedude committed May 16, 2019
    Configuration menu
    Copy the full SHA
    746d6dd View commit details
    Browse the repository at this point in the history