Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New field to set 'coin:ss:idp_visible_only' #664

Merged
merged 6 commits into from
Sep 2, 2024
Merged

New field to set 'coin:ss:idp_visible_only' #664

merged 6 commits into from
Sep 2, 2024

Commits on Aug 29, 2024

  1. Show the idpVisibleOnly checkbox on forms 

    And carry them in on the Save commands
    @MKodde
    MKodde committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    ef82e9b View commit details
    Browse the repository at this point in the history

  2. Transport the idpVisibleOnly value to the Coin VO

    @MKodde
    MKodde committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    1bacd8b View commit details
    Browse the repository at this point in the history

  3. Set the Idp Visible value correctly on the form 

    When editing an existing entity
    @MKodde
    MKodde committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    37e1662 View commit details
    Browse the repository at this point in the history

  4. Sharpen the EntityDiff algo 

    The check would be type unspecific. That resulted in situations where "" would
be considered null. That resulted in the new coin value to never be set
for existing entities. As null would also evaluate to be true when the
new value for the value is `false`. As php thinks false == null when not testing
in a strict manner.
    @MKodde
    MKodde committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    093df05 View commit details
    Browse the repository at this point in the history

  5. Display the isIdpVisibleOnly in view mode

    @MKodde
    MKodde committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    66c4638 View commit details
    Browse the repository at this point in the history

  6. Adjust form labels according to text in story 

    See: https://www.pivotaltracker.com/story/show/187515050
    @MKodde
    MKodde committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    0ab321c View commit details
    Browse the repository at this point in the history