New field to set 'coin:ss:idp_visible_only' #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MKodde
force-pushed
the
feature/visible-only
branch
3 times, most recently
from
45147df
to
586ff59
Compare
parijke
reviewed
Aug 25, 2024
...rviceProviderDashboard/Application/Command/Entity/SaveOauthClientCredentialClientCommand.php
Show resolved
Hide resolved
src/Surfnet/ServiceProviderDashboard/Application/Command/Entity/SaveSamlEntityCommand.php
Show resolved
Hide resolved
| @@ -227,7 +227,9 @@ private function generateMetadataFields(ManageEntity $entity): array | |||
| if ($entity->getMetaData()->getLogo() instanceof Logo && $entity->getMetaData()->getLogo()->getUrl() !== '') { | |||
| $metadata = array_merge($metadata, $this->generateLogoMetadata($entity)); | |||
| } | |||
|
|
|||
| if ($entity->getMetaData()?->getCoin()->isIdpVisibleOnly() !== null) { | |||
There was a problem hiding this comment.
What does this mean? Tis is a fairly complex equation, and it is not clear what is meant. Using a descriptive method could maybe clarify a bit
There was a problem hiding this comment.
What part of the equation is complex in your opinion? I find it rather expressive, but I'm kind of biassed ;P
There was a problem hiding this comment.
The whole part... I have no idea what true and false mean in this case. What means true here in 1 word?
MKodde
force-pushed
the
feature/visible-only
branch
4 times, most recently
from
6591958
to
076f04f
Compare
And carry them in on the Save commands
When editing an existing entity
The check would be type unspecific. That resulted in situations where "" would be considered null. That resulted in the new coin value to never be set for existing entities. As null would also evaluate to be true when the new value for the value is `false`. As php thinks false == null when not testing in a strict manner.
MKodde
force-pushed
the
feature/visible-only
branch
from
076f04f
to
0ab321c
Compare
parijke
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SAML and OIDC entities now allow for setting the coin:ss:idp_visible_only metadata setting. See the story for the fine details.
See: https://www.pivotaltracker.com/story/show/187515050