Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: eda refresh outdated view #1215

Merged
merged 32 commits into from
Jun 29, 2024
Merged

Conversation

SmiteDeluxe
Copy link
Contributor

@SmiteDeluxe SmiteDeluxe commented Jun 21, 2024

Closes #1214

Summary of Changes

If a tab that is outdated (heatmap with hidden column after creation) then there are now buttons to refresh in current or new tab.

WARNING: Includes right click improvements and history PR, those should be done first.

 & fix: dont open new context menu if $prevent clicks and currentMenu open not already the same one, thus allowing repositioning of same context menu
@SmiteDeluxe SmiteDeluxe added enhancement 💡 New feature or request vscode 🔨 Issues regarding tools like the VS Code extension labels Jun 21, 2024
@SmiteDeluxe SmiteDeluxe linked an issue Jun 21, 2024 that may be closed by this pull request
@SmiteDeluxe SmiteDeluxe changed the title 1214 eda refresh outdated view feat: eda refresh outdated view Jun 21, 2024
Copy link

github-actions bot commented Jun 21, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ JSON prettier 1 0 0 1.0s
✅ REPOSITORY git_diff yes no 0.17s
✅ TSX eslint 1 0 0 4.83s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.79%. Comparing base (cf440e3) to head (9077172).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1215   +/-   ##
=======================================
  Coverage   99.79%   99.79%           
=======================================
  Files         110      110           
  Lines       19247    19247           
  Branches     4110     4110           
=======================================
  Hits        19207    19207           
  Misses         40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lars-reimann lars-reimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@lars-reimann lars-reimann merged commit 2295d80 into main Jun 29, 2024
7 checks passed
@lars-reimann lars-reimann deleted the 1214-eda-refresh-outdated-view branch June 29, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 💡 New feature or request vscode 🔨 Issues regarding tools like the VS Code extension
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

EDA: refresh outdated view
2 participants