Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keeping no columns with Table.keep_only_columns results in an empty Table with a row count above 0 #318

Closed
Marsmaennchen221 opened this issue May 24, 2023 · 2 comments · Fixed by #386
Closed

Keeping no columns with Table.keep_only_columns results in an empty Table with a row count above 0 #318

Marsmaennchen221 opened this issue May 24, 2023 · 2 comments · Fixed by #386
Assignees
@alex-senger @patrikguempel
Labels
bug 🪲 Something isn't working released Included in a release

Comments

@Marsmaennchen221
Copy link
Contributor

Marsmaennchen221 commented May 24, 2023 •
edited
Loading

Describe the bug

If you use the method Table.keep_only_columns with an empty list on a table that contains at least one row, you get an empty table with a row count above 0.

The methods Table.remove_columns has the same bug if you remove all columns.

To Reproduce

from safeds.data.tabular.containers import Table

table = Table({"Column1": [1, 2, 3], "Column2": [4, 5, 6]})
table = table.keep_only_columns([])

print(table)
print(table.number_of_rows)

The print statement returns 3 but the table is empty

Expected behavior

The row count should be 0 if the table is empty

Screenshots (optional)

No response

Additional Context (optional)

No response
@Marsmaennchen221 Marsmaennchen221 added the bug 🪲 Something isn't working label May 24, 2023
@github-project-automation github-project-automation bot moved this to Backlog in Library May 24, 2023
@lars-reimann
Copy link
Member

lars-reimann commented May 24, 2023 •
edited
Loading

Related to #123.

@Marsmaennchen221 Marsmaennchen221 mentioned this issue May 24, 2023
Merged
@alex-senger alex-senger moved this from Backlog to Todo in Library Jun 23, 2023
@alex-senger alex-senger mentioned this issue Jun 23, 2023
Merged
@alex-senger alex-senger linked a pull request Jun 23, 2023 that will close this issue
fix: Keeping no columns with Table.keep_only_columns results in an empty Table with a row count above 0 #386
Merged
@alex-senger alex-senger moved this from Todo to Ready for Review in Library Jun 23, 2023
@alex-senger alex-senger moved this from Ready for Review to In Progress in Library Jun 23, 2023
@alex-senger alex-senger moved this from In Progress to Ready for Review in Library Jun 23, 2023
alex-senger added a commit that referenced this issue Jun 24, 2023
@alex-senger @patrikguempel
@megalinter-bot @sibre28
fix: Keeping no columns with Table.keep_only_columns results in an em…
15dab06 
…pty Table with a row count above 0 (#386)

Closes #318 

Fixes Bug:

If you use the method Table.keep_only_columns with an empty list on a
table that contains at least one row, you get an empty table with a row
count above 0.

### Summary of Changes

<!-- Please provide a summary of changes in this pull request, ensuring
all changes are explained. -->

---------

Co-authored-by: patrikguempel <patrikguempel@gmail.com>
Co-authored-by: megalinter-bot <129584137+megalinter-bot@users.noreply.github.com>
Co-authored-by: Simon Breuer <86068340+sibre28@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from Ready for Review to ✔️ Done in Library Jun 24, 2023
lars-reimann pushed a commit that referenced this issue Jun 30, 2023
@semantic-release-bot
chore(release): 0.14.0 [skip ci]
d6f012c 
## [0.14.0](v0.13.0...v0.14.0) (2023-06-30)

### Features

* 290 properties for width-height of image ([#359](#359)) ([d9ebdc1](d9ebdc1)), closes [#290](#290)
* Add `find_edges` method to `Image` class ([#383](#383)) ([d14b6ce](d14b6ce)), closes [#288](#288)
* Add `StandardScaler` transformer ([#316](#316)) ([57b0572](57b0572)), closes [#142](#142)
* Add docstrings to the getter methods for hyperparameters in Regression and Classification models ([#371](#371)) ([9073f04](9073f04)), closes [#313](#313)
* Added `Table.group_by` to group a table by a given key ([#343](#343)) ([afb98be](afb98be)), closes [#160](#160)
* Added and improved errors and warnings in the table transformers ([#372](#372)) ([544e307](544e307)), closes [#152](#152)
* added crop() method in image and tests ([#365](#365)) ([eba8163](eba8163))
* added invert_colors method ([#367](#367)) ([1e4d110](1e4d110))
* adjust brightness and contrast of image ([#368](#368)) ([1752feb](1752feb)), closes [#289](#289) [#291](#291)
* blur Image method ([#363](#363)) ([c642176](c642176))
* check that methods of table can handle an empty table ([#314](#314)) ([686c2e7](686c2e7)), closes [#123](#123)
* convert image to grayscale ([#366](#366)) ([1312fe7](1312fe7)), closes [#287](#287)
* enhance `replace_column` to accept a list of new columns ([#312](#312)) ([d50c5b5](d50c5b5)), closes [#301](#301)
* Explicitly throw `UnknownColumnNameError` in `TaggedTable._from_table` ([#334](#334)) ([498999f](498999f)), closes [#333](#333)
* flip images / eq method for image ([#360](#360)) ([54f4ae1](54f4ae1)), closes [#280](#280)
* improve `table.summary`. Catch `ValueError` thrown by `column.stability` ([#390](#390)) ([dbbe0e3](dbbe0e3)), closes [#320](#320)
* improve error handling of `column.stability` when given a column that contains only None ([#388](#388)) ([1da2499](1da2499)), closes [#319](#319)
* Improve Error Handling of classifiers and regressors ([#355](#355)) ([66f5f64](66f5f64)), closes [#153](#153)
* Resize image ([#354](#354)) ([3a971ca](3a971ca)), closes [#283](#283)
* rotate_left and rotate_right added to Image ([#361](#361)) ([c877530](c877530)), closes [#281](#281)
* set kernel of support vector machine ([#350](#350)) ([1326f40](1326f40)), closes [#172](#172)
* sharpen image ([#364](#364)) ([3444700](3444700)), closes [#286](#286)

### Bug Fixes

* Keeping no columns with Table.keep_only_columns results in an empty Table with a row count above 0 ([#386](#386)) ([15dab06](15dab06)), closes [#318](#318)
* remove default value of `positive_class` parameter of classifier metrics ([#382](#382)) ([58fc09e](58fc09e))
* remove default value of `radius` parameter of `blur` ([#378](#378)) ([7f07f29](7f07f29))
@lars-reimann
Copy link
Member

🎉 This issue has been resolved in version 0.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alex-senger alex-senger

@patrikguempel patrikguempel

Labels
bug 🪲 Something isn't working released Included in a release
Projects
Library
Archived in project
Milestone
No milestone
4 participants
@lars-reimann @Marsmaennchen221 @alex-senger @patrikguempel