-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: redesigned protocol #106
base: main
Are you sure you want to change the base?
Conversation
The `Task` provides an interface for cancellation
They don't work well with coroutines + we already offer means to cleanly shutdown.
🦙 MegaLinter status: ❌ ERROR
See detailed report in MegaLinter reports |
7e51fd6
to
5b0158d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
===========================================
- Coverage 100.00% 95.92% -4.08%
===========================================
Files 15 21 +6
Lines 787 712 -75
===========================================
- Hits 787 683 -104
- Misses 0 29 +29 ☔ View full report in Codecov by Sentry. |
# Conflicts: # poetry.lock # pyproject.toml # src/safeds_runner/server/_messages.py # src/safeds_runner/server/_pipeline_manager.py # tests/safeds_runner/server/test_websocket_mock.py
# Conflicts: # poetry.lock # pyproject.toml
# Conflicts: # poetry.lock # pyproject.toml # src/safeds_runner/server/_pipeline_manager.py # src/safeds_runner/server/_server.py # src/safeds_runner/server/messages/_from_server.py # tests/safeds_runner/server/test_server.py
Breaks when file gets formatted
Closes #22
Closes #90
Closes #92
Summary of Changes
save_placeholder
with two methods to either just report that a placeholder was computed and another to immediately send the value.progress
message to send percentage of work done and an optional message. We can later use this to report, say, how many epochs are already done when training a neural network.Message client -> server:
run
- run a pipelineshutdown
- shutdown the serverMessages server -> client:
placeholder_value
- send the value of a placeholderprogress
- report that a placeholder was computedruntime_warning
- report a warning while running the pipelineruntime_error
- report an error while running the pipelinedone
- finished running the pipelineTODOs
placeholder_value
messagetableWindows
argument ofrun
messagecwd
argument ofrun
message