Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: redesigned protocol #106

Draft
wants to merge 102 commits into
base: main
Choose a base branch
from
Draft

feat: redesigned protocol #106

wants to merge 102 commits into from

Commits on Apr 28, 2024

  1. feat: use Socket.io instead of plain websockets

    @lars-reimann
    lars-reimann committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    43ab7b3 View commit details
    Browse the repository at this point in the history

  2. build: add asyncio-client for socket.io

    @lars-reimann
    lars-reimann committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    7c2bf56 View commit details
    Browse the repository at this point in the history

  3. test: fixture to start server

    @lars-reimann
    lars-reimann committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    ea91022 View commit details
    Browse the repository at this point in the history

  4. test: demo test

    @lars-reimann
    lars-reimann committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    88cf763 View commit details
    Browse the repository at this point in the history

  5. fix: catch TypeErrors if unwrapping via ** fails

    @lars-reimann
    lars-reimann committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    5127572 View commit details
    Browse the repository at this point in the history

  6. fix: make startup awaitable

    @lars-reimann
    lars-reimann committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    35e4b5e View commit details
    Browse the repository at this point in the history

  7. fix: receive first message

    @lars-reimann
    lars-reimann committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    88c53d6 View commit details
    Browse the repository at this point in the history

  8. test: first working test

    @lars-reimann
    lars-reimann committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    1c6a04f View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. test: move tests for message validation

    @lars-reimann
    lars-reimann committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    3d61489 View commit details
    Browse the repository at this point in the history

  2. refactor: make several functions async

    @lars-reimann
    lars-reimann committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    0481396 View commit details
    Browse the repository at this point in the history

  3. docs: add some comments

    @lars-reimann
    lars-reimann committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    265667d View commit details
    Browse the repository at this point in the history

  4. refactor: rename attribute

    @lars-reimann
    lars-reimann committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    0a6f886 View commit details
    Browse the repository at this point in the history

  5. refactor: rename attribute

    @lars-reimann
    lars-reimann committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    f6a1fc0 View commit details
    Browse the repository at this point in the history

  6. refactor: return a Task instead of a Thread 

    The `Task` provides an interface for cancellation
    @lars-reimann
    lars-reimann committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    86c7cf9 View commit details
    Browse the repository at this point in the history

  7. test: automatically detect async

    @lars-reimann
    lars-reimann committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    db74187 View commit details
    Browse the repository at this point in the history

  8. refactor: move process termination handler into server

    @lars-reimann
    lars-reimann committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    a253889 View commit details
    Browse the repository at this point in the history

  9. test: handle shutdown and teardown of server in fixture

    @lars-reimann
    lars-reimann committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    5b11f37 View commit details
    Browse the repository at this point in the history

  10. refactor: remove atexit handlers 

    They don't work well with coroutines + we already offer means to cleanly shutdown.
    @lars-reimann
    lars-reimann committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    ce43e5e View commit details
    Browse the repository at this point in the history

  11. refactor: define outgoing messages with pydantic

    @lars-reimann
    lars-reimann committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    83da61e View commit details
    Browse the repository at this point in the history

  12. refactor: define incoming messages with pydantic

    @lars-reimann
    lars-reimann committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    b7227a8 View commit details
    Browse the repository at this point in the history

  13. fix: get test working again with new messages

    @lars-reimann
    lars-reimann committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    f0b3737 View commit details
    Browse the repository at this point in the history

  14. feat: send runtime warnings

    @lars-reimann
    lars-reimann committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    6ad67ed View commit details
    Browse the repository at this point in the history

  15. fix: deadlock

    @lars-reimann
    lars-reimann committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    8f44525 View commit details
    Browse the repository at this point in the history

  16. test: shutdown message

    @lars-reimann
    lars-reimann committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    748ae0c View commit details
    Browse the repository at this point in the history

  17. test: remove migrated tests

    @lars-reimann
    lars-reimann committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    fbf3afd View commit details
    Browse the repository at this point in the history

  18. test: comment out code that causes full test run to fail completely

    @lars-reimann
    lars-reimann committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    fb62727 View commit details
    Browse the repository at this point in the history

  19. test: update validation tests

    @lars-reimann
    lars-reimann committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    13def66 View commit details
    Browse the repository at this point in the history

  20. fix: run server in loop

    @lars-reimann
    lars-reimann committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    6af39c2 View commit details
    Browse the repository at this point in the history

  21. fix: arbitrary args for payload of shutdown/catch all

    @lars-reimann
    lars-reimann committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    ad216d8 View commit details
    Browse the repository at this point in the history

  22. test: fix stalling test

    @lars-reimann
    lars-reimann committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    5bdf067 View commit details
    Browse the repository at this point in the history

  23. test: update memo tests

    @lars-reimann
    lars-reimann committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    a9d9211 View commit details
    Browse the repository at this point in the history

  24. refactor: call sys.exit using the event loop 

    This avoids some logs about uncaught future exceptions
    @lars-reimann
    lars-reimann committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    2b9517a View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. feat: handle interrupt signal

    @lars-reimann
    lars-reimann committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    c8df399 View commit details
    Browse the repository at this point in the history

  2. refactor: shutdown server using interrupt signal

    @lars-reimann
    lars-reimann committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    e6f1584 View commit details
    Browse the repository at this point in the history

  3. refactor: extract interface into own package

    @lars-reimann
    lars-reimann committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    cd774dc View commit details
    Browse the repository at this point in the history

  4. fix: register signal handler in main thread

    @lars-reimann
    lars-reimann committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    adf6aed View commit details
    Browse the repository at this point in the history

  5. test: progress sent

    @lars-reimann
    lars-reimann committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    a54fdc2 View commit details
    Browse the repository at this point in the history

  6. test: add a means to send messages with two clients

    @lars-reimann
    lars-reimann committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    0922dad View commit details
    Browse the repository at this point in the history

  7. test: add more tests

    @lars-reimann
    lars-reimann committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    59182d0 View commit details
    Browse the repository at this point in the history

  8. test: remove migrated tests

    @lars-reimann
    lars-reimann committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    205f3d5 View commit details
    Browse the repository at this point in the history

  9. docs: document new messages

    @lars-reimann
    lars-reimann committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    74e89ce View commit details
    Browse the repository at this point in the history

  10. refactor: extract logic from pipeline process into interface methods

    @lars-reimann
    lars-reimann committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    24cbdfb View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. feat: use Socket.io instead of plain websockets

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    026baca View commit details
    Browse the repository at this point in the history

  2. build: add asyncio-client for socket.io

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    a6ff86b View commit details
    Browse the repository at this point in the history

  3. test: fixture to start server

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    e151888 View commit details
    Browse the repository at this point in the history

  4. test: demo test

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    039ea31 View commit details
    Browse the repository at this point in the history

  5. fix: catch TypeErrors if unwrapping via ** fails

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    d173782 View commit details
    Browse the repository at this point in the history

  6. fix: make startup awaitable

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    11d70da View commit details
    Browse the repository at this point in the history

  7. fix: receive first message

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    045a36e View commit details
    Browse the repository at this point in the history

  8. test: first working test

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    9a51528 View commit details
    Browse the repository at this point in the history

  9. test: move tests for message validation

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    e94476d View commit details
    Browse the repository at this point in the history

  10. refactor: make several functions async

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    f94c789 View commit details
    Browse the repository at this point in the history

  11. docs: add some comments

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    011fabc View commit details
    Browse the repository at this point in the history

  12. refactor: rename attribute

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    b0aa214 View commit details
    Browse the repository at this point in the history

  13. refactor: rename attribute

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    619c831 View commit details
    Browse the repository at this point in the history

  14. refactor: return a Task instead of a Thread 

    The `Task` provides an interface for cancellation
    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    6d214da View commit details
    Browse the repository at this point in the history

  15. test: automatically detect async

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    09a0964 View commit details
    Browse the repository at this point in the history

  16. refactor: move process termination handler into server

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    c72fcdc View commit details
    Browse the repository at this point in the history

  17. test: handle shutdown and teardown of server in fixture

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    4785da0 View commit details
    Browse the repository at this point in the history

  18. refactor: remove atexit handlers 

    They don't work well with coroutines + we already offer means to cleanly shutdown.
    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    852434b View commit details
    Browse the repository at this point in the history

  19. refactor: define outgoing messages with pydantic

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    ef8a03d View commit details
    Browse the repository at this point in the history

  20. refactor: define incoming messages with pydantic

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    9846a4a View commit details
    Browse the repository at this point in the history

  21. fix: get test working again with new messages

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    7624766 View commit details
    Browse the repository at this point in the history

  22. feat: send runtime warnings

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    88f6d3c View commit details
    Browse the repository at this point in the history

  23. fix: deadlock

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    8a95ffa View commit details
    Browse the repository at this point in the history

  24. test: shutdown message

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    8f29039 View commit details
    Browse the repository at this point in the history

  25. test: remove migrated tests

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    bb1484a View commit details
    Browse the repository at this point in the history

  26. test: comment out code that causes full test run to fail completely

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    5d7f200 View commit details
    Browse the repository at this point in the history

  27. test: update validation tests

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    26eeec1 View commit details
    Browse the repository at this point in the history

  28. fix: run server in loop

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    f5d0f82 View commit details
    Browse the repository at this point in the history

  29. fix: arbitrary args for payload of shutdown/catch all

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    18b5bc3 View commit details
    Browse the repository at this point in the history

  30. test: fix stalling test

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    7886c1b View commit details
    Browse the repository at this point in the history

  31. test: update memo tests

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    9ddd0af View commit details
    Browse the repository at this point in the history

  32. refactor: call sys.exit using the event loop 

    This avoids some logs about uncaught future exceptions
    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    8c3d3da View commit details
    Browse the repository at this point in the history

  33. feat: handle interrupt signal

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    26f8b61 View commit details
    Browse the repository at this point in the history

  34. refactor: shutdown server using interrupt signal

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    11c84bf View commit details
    Browse the repository at this point in the history

  35. refactor: extract interface into own package

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    1b81c77 View commit details
    Browse the repository at this point in the history

  36. fix: register signal handler in main thread

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    2eb2207 View commit details
    Browse the repository at this point in the history

  37. test: progress sent

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    de8af73 View commit details
    Browse the repository at this point in the history

  38. test: add a means to send messages with two clients

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    33b470e View commit details
    Browse the repository at this point in the history

  39. test: add more tests

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    48215ce View commit details
    Browse the repository at this point in the history

  40. test: remove migrated tests

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    5303ad3 View commit details
    Browse the repository at this point in the history

  41. docs: document new messages

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    621e5ee View commit details
    Browse the repository at this point in the history

  42. refactor: extract logic from pipeline process into interface methods

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    9bd7797 View commit details
    Browse the repository at this point in the history

  43. build: regenerate lockfile

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    5923ba6 View commit details
    Browse the repository at this point in the history

  44. test: always stop server used to test shutdown message

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    d9414a8 View commit details
    Browse the repository at this point in the history

  45. feat: method to check whether server is started

    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    c2e8ea3 View commit details
    Browse the repository at this point in the history

  46. test: wait until the server to test shutdown is ready to accept conne… 

    …ctions
    @lars-reimann
    lars-reimann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    88f6f56 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2024

  1. Merge branch 'refs/heads/main' into socket-io 

    # Conflicts:
#	poetry.lock
#	pyproject.toml
#	src/safeds_runner/server/_messages.py
#	src/safeds_runner/server/_pipeline_manager.py
#	tests/safeds_runner/server/test_websocket_mock.py
    @lars-reimann
    lars-reimann committed May 4, 2024
    Configuration menu
    Copy the full SHA
    abd5628 View commit details
    Browse the repository at this point in the history

  2. WIP

    @lars-reimann
    lars-reimann committed May 4, 2024
    Configuration menu
    Copy the full SHA
    145edfb View commit details
    Browse the repository at this point in the history

  3. Merge branch 'refs/heads/main' into socket-io 

    # Conflicts:
#	poetry.lock
#	pyproject.toml
    @lars-reimann
    lars-reimann committed May 4, 2024
    Configuration menu
    Copy the full SHA
    9d0b025 View commit details
    Browse the repository at this point in the history

  4. build: merge dependencies

    @lars-reimann
    lars-reimann committed May 4, 2024
    Configuration menu
    Copy the full SHA
    ba59134 View commit details
    Browse the repository at this point in the history

  5. ci: remove mypy plugin

    @lars-reimann
    lars-reimann committed May 4, 2024
    Configuration menu
    Copy the full SHA
    6da43a4 View commit details
    Browse the repository at this point in the history

  6. refactor: move method to get runtime type

    @lars-reimann
    lars-reimann committed May 4, 2024
    Configuration menu
    Copy the full SHA
    bd1ae3e View commit details
    Browse the repository at this point in the history

  7. refactor: utils to create stacktraces

    @lars-reimann
    lars-reimann committed May 4, 2024
    Configuration menu
    Copy the full SHA
    d9259af View commit details
    Browse the repository at this point in the history

  8. test: automatically detect async

    @lars-reimann
    lars-reimann committed May 4, 2024
    Configuration menu
    Copy the full SHA
    b586aef View commit details
    Browse the repository at this point in the history

  9. fix: allow line of stacktrace entry to be None

    @lars-reimann
    lars-reimann committed May 4, 2024
    Configuration menu
    Copy the full SHA
    f9e5319 View commit details
    Browse the repository at this point in the history

  10. Merge remote-tracking branch 'origin/socket-io' into socket-io 

    # Conflicts:
#	poetry.lock
#	pyproject.toml
#	src/safeds_runner/server/_pipeline_manager.py
#	src/safeds_runner/server/_server.py
#	src/safeds_runner/server/messages/_from_server.py
#	tests/safeds_runner/server/test_server.py
    @lars-reimann
    lars-reimann committed May 4, 2024
    Configuration menu
    Copy the full SHA
    7fd0bd7 View commit details
    Browse the repository at this point in the history

  11. test: don't compare exact line numbers 

    Breaks when file gets formatted
    @lars-reimann
    lars-reimann committed May 4, 2024
    Configuration menu
    Copy the full SHA
    3862377 View commit details
    Browse the repository at this point in the history

  12. refactor: extract tree_kill function

    @lars-reimann
    lars-reimann committed May 4, 2024
    Configuration menu
    Copy the full SHA
    706dba2 View commit details
    Browse the repository at this point in the history

  13. test: double the timeout

    @lars-reimann
    lars-reimann committed May 4, 2024
    Configuration menu
    Copy the full SHA
    4999aed View commit details
    Browse the repository at this point in the history

  14. feat: convert values

    @lars-reimann
    lars-reimann committed May 4, 2024
    Configuration menu
    Copy the full SHA
    e0d0296 View commit details
    Browse the repository at this point in the history