Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_heartrate failing for psd and peak methods #179

Open
itismeghasyam opened this issue Feb 5, 2019 · 3 comments
Open

get_heartrate failing for psd and peak methods #179

itismeghasyam opened this issue Feb 5, 2019 · 3 comments
Assignees
@itismeghasyam

Comments

@itismeghasyam
Copy link
Contributor

itismeghasyam commented Feb 5, 2019 •
edited
Loading

The problem is in the if statement in L#226. You just need to run by this loop if the method is 'acf'. Infact just comment this out
@philerooski
Copy link
Collaborator

Is this something we can write tests for?

@itismeghasyam
Copy link
Contributor Author

If we can hard-code some stuff, then yes. But ideally we should be able to at least check the data types of the output for various values of the parameter method. Will include some tests for the datatype check in the next PR 👍

This was referenced Feb 7, 2019
Closed
Closed
Merged
@itismeghasyam
Copy link
Contributor Author

@larssono Should we still retain the PSD and peak methods in the mhealthtools package or just retain the working acf model?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@itismeghasyam itismeghasyam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@philerooski @itismeghasyam