Vignette develop #183
Closed
Vignette develop #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting up to date with Sage - Bionetworks Develop
- Removed data/sensor_data.rda - roxygenized the package
Commented L#225 - L#229. It is a If loop that makes the hr values NA if the confidence values are NA
- Phil, your input is needed. Can you please write a sample use case of funs(custom defined funs) and models parameter for gyroscope and accelerometer data?
- Updated the modules and sensors vignettes to reflect the changes in the package - The vignette's have a line ## PHIL'S INPUT NEEDED HERE (A sample example for using funs and models), Phil please comment it out once you have addressed it
Merge pull request #27 from Sage-Bionetworks/develop
if any of the outputs are null, they are recast as NAs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#179
#144