Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vignette develop #182

Closed

Conversation

itismeghasyam
Copy link
Contributor

  • Resolves get_heartrate failing for psd and peak methods #179 (I didn't write the tests because commenting out that code totally eliminates that problem)
  • Update vignettes #144 - Sensors and Modules vignettes are now updated to reflect new architecture of the package. Also Phil can you please include examples for using funs and models in these vignettes ?
  • I also made changes to heartrate_data. It now has only columns t, red, green and blue and a much better illustrative record. Before we had some record that was not as illustrative and also we had extra columns of brightness, hue and saturation.

Getting up to date with Sage - Bionetworks Develop
- Removed data/sensor_data.rda
- roxygenized the package
Commented L#225 - L#229. It is a If loop that makes the hr values NA if the confidence values are NA
- Phil, your input is needed. Can you please write a sample use case of funs(custom defined funs) and models parameter for gyroscope and accelerometer data?
- Updated the modules and sensors vignettes to reflect the changes in the package
- The vignette's have a line ## PHIL'S INPUT NEEDED HERE (A sample example for using funs and models),
Phil please comment it out once you have addressed it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant