Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab axe warning when rendering a link #4517

Closed
1 task done
edleeks87 opened this issue Oct 26, 2021 · 2 comments · Fixed by #4568
Closed
1 task done

Tab axe warning when rendering a link #4517

edleeks87 opened this issue Oct 26, 2021 · 2 comments · Fixed by #4568

Comments

@edleeks87
Copy link
Contributor

edleeks87 commented Oct 26, 2021

Current behaviour

When an href string is passed to a Tab it renders an anchor element which causes an axe warning about nested interactive controls

Expected behaviour

No axe warning please

CodeSandbox or Storybook URL

https://carbon.sage.com/?path=/story/tabs--with-link-as-a-tab

JIRA Ticket (Sage Only)

No response

Suggested Solution

No response

Carbon Version

latest

What browsers are you seeing the problem on?

Firefox, Chrome, Safari, Microsoft Edge

What Operating System are you seeing the problem on?

MacOS

Anything else we should know?

No response

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@samtjo
Copy link
Contributor

samtjo commented Nov 2, 2021

FE-4441

@samtjo samtjo added On Backlog and removed triage Triage Required labels Nov 2, 2021
edleeks87 added a commit that referenced this issue Nov 26, 2021
…l and li elements

`TabHeader` now renders a `div` container and `TabTitle` renders either a `button` or `a` element.
This fixes accesibility issues raised against the old implementation relating to focusable children
not being read out by screen readers: `tabIndex` for `ValidataionIcon` is now null and
`customLayout` story has been updated to remove `ActionPopover`.

fix #4517
carbonci pushed a commit that referenced this issue Nov 26, 2021
### [101.3.1](v101.3.0...v101.3.1) (2021-11-26)

### Bug Fixes

* **tab-header, tab-title:** refactor components to no longer render ul and li elements ([42be1eb](42be1eb)), closes [#4517](#4517)
@carbonci
Copy link
Collaborator

🎉 This issue has been resolved in version 101.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants