docs(tabs): update headerWidth story to use unique id for each tab child FE-4440 #4568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 42be1eb:
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
edleeks87
force-pushed
the
FE-4440-tab-access-issues
branch
2 times, most recently
from
9297cb0 to
ada2e58
Compare
samtjo
previously approved these changes
Nov 18, 2021
DipperTheDan
approved these changes
Nov 18, 2021
DipperTheDan
previously approved these changes
Nov 18, 2021
edleeks87
force-pushed
the
FE-4440-tab-access-issues
branch
3 times, most recently
from
8644e7c to
713e0a9
Compare
DipperTheDan
previously approved these changes
Nov 18, 2021
samtjo
previously approved these changes
Nov 19, 2021
|
|
edleeks87
force-pushed
the
FE-4440-tab-access-issues
branch
from
fc0449a to
8ebb263
Compare
DipperTheDan
previously approved these changes
Nov 23, 2021
samtjo
previously approved these changes
Nov 23, 2021
|
I had a look at the before/after on this update and its not a problem for me, the visuals look fine. all good ✅ |
edleeks87
force-pushed
the
FE-4440-tab-access-issues
branch
2 times, most recently
from
15fb064 to
4055d86
Compare
The story has multiple `Tab` components witht the same `tabId` which causes axe warnings to be generated fix #4524
…l and li elements `TabHeader` now renders a `div` container and `TabTitle` renders either a `button` or `a` element. This fixes accesibility issues raised against the old implementation relating to focusable children not being read out by screen readers: `tabIndex` for `ValidataionIcon` is now null and `customLayout` story has been updated to remove `ActionPopover`. fix #4517
edleeks87
force-pushed
the
FE-4440-tab-access-issues
branch
from
4055d86 to
42be1eb
Compare
DlgSHi
approved these changes
Nov 26, 2021
samtjo
approved these changes
Nov 26, 2021
|
🎉 This PR is included in version 101.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4517
fix #4524
Proposed behaviour
The
headerWidthstory has multipleTabcomponents with the sametabIdwhich causes axe warnings to be generatedTabHeadernow renders adivcontainer andTabTitlerenders either abuttonoraelement. This fixes accessibility issues raised against the old implementation relating to focusable children not being read out by screen readers:tabIndexforValidationIconis now null andcustomLayoutstory has been updated to removeActionPopover.Current behaviour
Renders
ulandlielements, has multiple accessibility errors on storiesNo
d.tsfiles forTabTitleandTabHeaderChecklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions
Test all Tabs stories for accessibility errors and to confirm no regressions after refactor away from
ulliThe following CodeSandbox is an example of the broken behaviour.
You can see the new behaviour by looking at the version in the comment by
codesandbox[bot].