Accessibility Pod Title prop always shown H4 #4607
Comments
|
FE-4493 |
nicktitchmarsh
added
On Backlog
Design System Review Required
|
Design system to clarify if they want Pod to have different title weights above H4. Or if content designers should be discouraged from putting higher heading tags in the body of a Pod |
|
@nicktitchmarsh have you heard anymore about this? |
|
I had added to the JIRA ticket a possible solution of allowing |
|
Does that mean we can remove the triage label and do this ticket then @nicktitchmarsh or do we still need DS input as well? |
nicktitchmarsh
removed
the
Design System Review Required
surfaces the `headingType` prop on the component to provide consumers with the ability to specify which level of section headings they wish to apply from h1 to h5 when the `title` prop is a string. Also conditional rendering is now used to ensure when `title` is passed as a node it is not wrapped in any other section headings fix #4607
surfaces the `headingType` prop on the component to provide consumers with the ability to specify which level of section headings they wish to apply from h1 to h5 when the `title` prop is a string. Also conditional rendering is now used to ensure when `title` is passed as a node it is not wrapped in any other section headings fix #4607
the `title` and `subtitle` props can now be passed as a node, providing consumers with the ability to pass components such as `Typography` to control what element is rendered and its appearance. Also, conditional rendering has been used to ensure when `title` is passed as a node is not wrapped in any other section headings fix #4607
the `title` and `subtitle` props can now be passed as a node, providing consumers with the ability to pass components such as `Typography` to control what element is rendered and its appearance. Also, conditional rendering has been used to ensure when `title` is passed as a node is not wrapped in any other section headings fix #4607
|
This issue has been automatically marked as stale because it has not had recent activity. If you believe this issue is still valid and required please comment below. It will be reviewed by the core Carbon team and may be closed if no further activity occurs. Thank you for your contributions. |
## [119.12.0](v119.11.0...v119.12.0) (2023-08-21) ### Features * **pod:** allow title and subtitle to be passed as a node ([efdc827](efdc827)), closes [#4607](#4607)
|
🎉 This issue has been resolved in version 119.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Desired behaviour
Be able to use a similar prop as "as" present in typography to modify the rendered title element to solve Accessibility issues coming from SBS-24478
Current behaviour
Always returning an H4 element besides his internal rendered node which may be even an H3, H2.
Suggested Solution
No response
CodeSandbox or Storybook URL
https://carbon.sage.com/iframe.html?id=pod--default-story&viewMode=docs#pod-1
Anything else we should know?
SBS-24478
Confidentiality
The text was updated successfully, but these errors were encountered: