Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow different heading levels to be used in Setting Row component #5723

Closed
1 task done
laurenmccourt opened this issue Jan 4, 2023 · 2 comments · Fixed by #5806
Closed
1 task done

Allow different heading levels to be used in Setting Row component #5723

laurenmccourt opened this issue Jan 4, 2023 · 2 comments · Fixed by #5806
Labels
Enhancement On Backlog released

Comments

@laurenmccourt
Copy link

laurenmccourt commented Jan 4, 2023 •
edited
Loading

Desired behaviour

When using the 'Setting Row' component, have the ability to choose what level of heading you require for the 'Title' element. This will resolve the accessibility issue of using headings in non-sequential order.

Similar issue to #4607

Current behaviour

The 'Setting Row' component Title always uses a h1 for the Title element.

Suggested Solution

Allowing use of heading styles defined in the Typography component, or more flexibility in the Heading component to choose which level of heading you require.

CodeSandbox or Storybook URL

https://carbon.sage.com/?path=/docs/setting-row--default-story

Anything else we should know?

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@laurenmccourt laurenmccourt added Enhancement triage Triage Required labels Jan 4, 2023
@Parsium
Copy link
Contributor

Parsium commented Jan 10, 2023

FE-5610

@Parsium Parsium added On Backlog and removed triage Triage Required labels Jan 10, 2023
tomdavies73 added a commit that referenced this issue Feb 3, 2023
@tomdavies73
feat(settings-row): surface headingLevel prop on component
9a13447 
surfaces the `headingLevel` prop on the `SettingsRow` component to provide
consumers with the ability to specify which level of section headings they wish to apply
from h1 to h6.

fix #5723
@tomdavies73 tomdavies73 mentioned this issue Feb 3, 2023
Merged
14 tasks
tomdavies73 added a commit that referenced this issue Feb 3, 2023
@tomdavies73
feat(settings-row): surface headingLevel prop on component
c266ac3 
surfaces the `headingLevel` prop on the `SettingsRow` component to provide
consumers with the ability to specify which level of section headings they wish to apply
from h1 to h6.

fix #5723
tomdavies73 added a commit that referenced this issue Feb 7, 2023
@tomdavies73
feat(settings-row, heading): surface headingType prop on components
0b289ef 
surfaces the `headingType` prop on the `SettingsRow` and `Heading` components to provide
consumers with the ability to specify which level of section headings they wish to apply
from h1 to h6.

fix #5723
tomdavies73 added a commit that referenced this issue Feb 7, 2023
@tomdavies73
feat(settings-row, heading): surface headingType prop on components
c98891b 
surfaces the `headingType` prop on the `SettingsRow` and `Heading` components to provide
consumers with the ability to specify which level of section headings they wish to apply
from h1 to h6.

fix #5723
tomdavies73 added a commit that referenced this issue Feb 7, 2023
@tomdavies73
feat(settings-row, heading): surface headingType prop on components
d1ccff0 
surfaces the `headingType` prop on the `SettingsRow` and `Heading` components to provide
consumers with the ability to specify which level of section headings they wish to apply
from h1 to h6.

fix #5723
tomdavies73 added a commit that referenced this issue Feb 9, 2023
@tomdavies73
surfaces the headingType prop on the SettingsRow and Heading co…
d84b24b 
…mponents to provide consumers

with the ability to specify which level of section headings they wish to apply from h1 to h6.

BREAKING CHANGE: default heading level on `SettingsRow` is changed from `h1` to `h4`

fix #5723
tomdavies73 added a commit that referenced this issue Feb 9, 2023
@tomdavies73
feat(settings-row,heading): surface headingType prop on components
054c11a 
surfaces the `headingType` prop on the `SettingsRow` and `Heading` components to provide consumers
with the ability to specify which level of section headings they wish to apply from h1 to h6.

BREAKING CHANGE: default heading level on `SettingsRow` is changed from `h1` to `h4`

fix #5723
tomdavies73 added a commit that referenced this issue Feb 17, 2023
@tomdavies73
feat(settings-row,heading): surface headingType prop on components
d18e926 
surfaces the `headingType` prop on the `SettingsRow` and `Heading` components to provide consumers
with the ability to specify which level of section headings they wish to apply from h1 to h5.

BREAKING CHANGE: default heading level on `SettingsRow` is changed from `h1` to `h3`

fix #5723
tomdavies73 added a commit that referenced this issue Feb 21, 2023
@tomdavies73
feat(settings-row,heading): surface headingType prop on components
7f53917 
surfaces the `headingType` prop on the `SettingsRow` and `Heading` components to provide consumers
with the ability to specify which level of section headings they wish to apply from h1 to h5.

fix #5723
carbonci pushed a commit that referenced this issue Feb 21, 2023
@semantic-release-bot @carbonci
chore(release): 114.16.0
fda71f5 
## [114.16.0](v114.15.0...v114.16.0) (2023-02-21)

### Features

* **settings-row,heading:** surface headingType prop on components ([7f53917](7f53917)), closes [#5723](#5723)
@carbonci
Copy link
Collaborator

🎉 This issue has been resolved in version 114.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement On Backlog released
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(settings-row, heading): surface headingType prop on components Sage/carbon
3 participants
@Parsium @laurenmccourt @carbonci