Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tabs] contrast when in Drawer sidebar or using variant="alternate" is too low #5030

Closed
1 task done
edleeks87 opened this issue Apr 8, 2022 · 2 comments · Fixed by #5032
Closed
1 task done

[Tabs] contrast when in Drawer sidebar or using variant="alternate" is too low #5030

edleeks87 opened this issue Apr 8, 2022 · 2 comments · Fixed by #5032
Assignees
@edleeks87
Labels
Bug On Backlog released Squad Front End tabs

Comments

@edleeks87
Copy link
Contributor

Current behaviour

There is not enough contrast so it is unclear which Tab is selected
image

Expected behaviour

There should be enough contrast so that it is clear which Tab is selected

CodeSandbox or Storybook URL

https://carbon.sage.com/?path=/story/drawer--with-tab-controls&globals=theme:aegean

JIRA Ticket (Sage Only)

No response

Suggested Solution

No response

Carbon Version

latest

What browsers are you seeing the problem on?

Firefox, Chrome, Safari, Microsoft Edge

What Operating System are you seeing the problem on?

MacOS

Anything else we should know?

No response

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@edleeks87 edleeks87 self-assigned this Apr 8, 2022
@edleeks87
Copy link
Contributor Author

FE-5120

@edleeks87 edleeks87 added On Backlog and removed triage Triage Required labels Apr 8, 2022
edleeks87 added a commit that referenced this issue Apr 8, 2022
@edleeks87
fix(tabs): update background colour to improve contrast for selected …
02aed28 
…Tab in alternate variant

Updates the background colour for selcected or hovered `Tab` when `Tabs` are rendered inside the
`Drawer` `sidebar` or when `variant` is set to `alternate`

fix #5030
edleeks87 added a commit that referenced this issue Apr 8, 2022
@edleeks87
fix(tabs): update background colour to improve contrast for selected …
2af38b7 
…Tab in alternate variant

Updates the background colour for selected or hovered `Tab` when `Tabs` are rendered inside the
`Drawer` `sidebar` or when `variant` is set to `alternate`

fix #5030
@edleeks87 edleeks87 mentioned this issue Apr 8, 2022
Merged
8 tasks
carbonci pushed a commit that referenced this issue Apr 12, 2022
@semantic-release-bot @carbonci
chore(release): 106.0.1
5439351 
### [106.0.1](v106.0.0...v106.0.1) (2022-04-12)

### Bug Fixes

* **tabs:** update background colour to improve contrast for selected Tab in alternate variant ([2af38b7](2af38b7)), closes [#5030](#5030)
@carbonci
Copy link
Collaborator

🎉 This issue has been resolved in version 106.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

stephenogorman pushed a commit that referenced this issue Apr 25, 2022
@edleeks87 @stephenogorman
fix(tabs): update background colour to improve contrast for selected …
d99b37e 
…Tab in alternate variant

Updates the background colour for selected or hovered `Tab` when `Tabs` are rendered inside the
`Drawer` `sidebar` or when `variant` is set to `alternate`

fix #5030
stephenogorman pushed a commit that referenced this issue Apr 25, 2022
@semantic-release-bot @stephenogorman
chore(release): 106.0.1
20f2744 
### [106.0.1](v106.0.0...v106.0.1) (2022-04-12)

### Bug Fixes

* **tabs:** update background colour to improve contrast for selected Tab in alternate variant ([2af38b7](2af38b7)), closes [#5030](#5030)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edleeks87 edleeks87

Labels
Bug On Backlog released Squad Front End tabs
Milestone
No milestone
2 participants
@edleeks87 @carbonci