fix(tabs): update background colour to improve contrast for selected Tab in alternate variant FE-5120 #5032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Tab in alternate variant Updates the background colour for selected or hovered `Tab` when `Tabs` are rendered inside the `Drawer` `sidebar` or when `variant` is set to `alternate` fix #5030
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d733de0:
|
grabkowski
approved these changes
Apr 8, 2022
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
DipperTheDan
approved these changes
Apr 8, 2022
DipperTheDan
approved these changes
Apr 8, 2022
ZhuoyuJin
approved these changes
Apr 11, 2022
|
🎉 This PR is included in version 106.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5030
Proposed behaviour
Updates the background colour for selected or hovered
TabwhenTabsare rendered inside theDrawersidebaror whenvariantis set toalternateCurrent behaviour
Contrast is too low when Tabs are rendered in Drawer sidebar or variant is "alternate"
Checklist
QA
Additional context
Proposed look after updates:
Testing instructions
Test
tabs--with-alternate-stylingstoryTest
drawer--with-tab-controlsstoryThe following CodeSandbox is an example of the broken behaviour.
You can see the new behaviour by looking at the version in the comment by
codesandbox[bot].