Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky column with wrapper component is not working properly #5208

Closed
1 task done
StylianosKoidakisSage opened this issue Jun 8, 2022 · 2 comments · Fixed by #5214
Closed
1 task done

Sticky column with wrapper component is not working properly #5208

StylianosKoidakisSage opened this issue Jun 8, 2022 · 2 comments · Fixed by #5214

Comments

@StylianosKoidakisSage
Copy link

Current behaviour

When we use custom wrapper components for the cells the sticky functionality is not working properly and we always have 1 column sticky even there are more cols before

image

Expected behaviour

Should work as here: https://carbon.sage.com/?path=/docs/flat-table--with-custom-horizontal-border-color#with-row-headers

image

CodeSandbox or Storybook URL

https://codesandbox.io/s/quirky-satoshi-rtge9t?file=/src/index.js

JIRA Ticket (Sage Only)

No response

Suggested Solution

No response

Carbon Version

101.0.2

Design Tokens Version

No response

What browsers are you seeing the problem on?

Chrome

What Operating System are you seeing the problem on?

MacOS

Anything else we should know?

No response

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@StylianosKoidakisSage StylianosKoidakisSage added Bug triage Triage Required labels Jun 8, 2022
@edleeks87
Copy link
Contributor

FE-5208

@edleeks87 edleeks87 added On Backlog and removed triage Triage Required labels Jun 8, 2022
edleeks87 added a commit that referenced this issue Jun 9, 2022
…apping row headers

Updates functionality to use `child.type.displayName` instead of `child.type`. This will allow
wrapping of the `FlatTableRowHeader` component as the wrapper component can set its `displayName` to
`FlatTableRowHeader.displayName` to ensure the required columns are sticky.

fix #5208
edleeks87 added a commit that referenced this issue Jun 9, 2022
…apping row headers

Updates functionality to use `child.type.displayName` instead of `child.type`. This will allow
wrapping of the `FlatTableRowHeader` component as the wrapper component can set its `displayName` to
`FlatTableRowHeader.displayName` to ensure the required columns are sticky.

fix #5208
edleeks87 added a commit that referenced this issue Jun 17, 2022
…apping row headers

Updates functionality to use `child.type.displayName` instead of `child.type`. This will allow
wrapping of the `FlatTableRowHeader` component as the wrapper component can set its `displayName` to
`FlatTableRowHeader.displayName` to ensure the required columns are sticky.

fix #5208
carbonci pushed a commit that referenced this issue Jun 17, 2022
### [107.1.6](v107.1.5...v107.1.6) (2022-06-17)

### Bug Fixes

* **flat-table-row:** update sticky column functionality to support wrapping row headers ([d15cb0d](d15cb0d)), closes [#5208](#5208)
@carbonci
Copy link
Collaborator

🎉 This issue has been resolved in version 107.1.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants