chore(flat-table-header): add displayName to component FE-5208 #5214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d15cb0d:
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
edleeks87
force-pushed
the
FE-5208-wrapping-sticky-col
branch
5 times, most recently
from
7434fc8 to
5ed77e7
Compare
edleeks87
changed the title
edleeks87
force-pushed
the
FE-5208-wrapping-sticky-col
branch
from
5ed77e7 to
8042c45
Compare
edleeks87
added
Pending Review
Pending QA
No UX QA Required
Squad Front End
and removed
DO NOT MERGE
labels
DipperTheDan
previously approved these changes
Jun 9, 2022
Parsium
previously approved these changes
Jun 15, 2022
…apping row headers Updates functionality to use `child.type.displayName` instead of `child.type`. This will allow wrapping of the `FlatTableRowHeader` component as the wrapper component can set its `displayName` to `FlatTableRowHeader.displayName` to ensure the required columns are sticky. fix #5208
edleeks87
force-pushed
the
FE-5208-wrapping-sticky-col
branch
from
19e86a9 to
d15cb0d
Compare
DipperTheDan
approved these changes
Jun 17, 2022
ZhuoyuJin
approved these changes
Jun 17, 2022
|
🎉 This PR is included in version 107.1.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5208
Proposed behaviour
Updates functionality to use
child.type.displayNameinstead ofchild.type. This will allowwrapping of the
FlatTableRowHeadercomponent as the wrapper component can set itsdisplayNametoFlatTableRowHeader.displayNameto ensure the required columns are sticky.Adds
displayNameproperty to children ofFlatTableRow.Current behaviour
Wrapping the
FlatTableRowHeaderprevents sticky column functioning correctlyChildren of
FlatTableRowhave nodisplayNamepropertyChecklist
QA
Additional context
Testing instructions
Use sandbox below, the one included in the linked issue will not work as there is no way to dynamically set the displayName on the wrapper. I have also added a story to demo how to implement this
flat-table--wrapping-row-headersThe following CodeSandbox is an example of the broken behaviour.
You can see the new behaviour by looking at the version in the comment by
codesandbox[bot].https://codesandbox.io/s/carbon-quickstart-forked-y63erp?file=/src/index.js